IDB: Add more IsShuttingDown checks to database maintenance
Categories
(Core :: Storage: IndexedDB, task, P1)
Tracking
()
People
(Reporter: janv, Assigned: janv)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
According to:
https://crash-stats.mozilla.org/report/index/6803ac22-3260-4342-bfad-624330190607#tab-metadata
the IDB shutdown timer fired when an IDB maintenance thread was actively running the integrity check. This can take long time on a big database. DatabaseMaintenance::AutoProgressHandler::OnProgress now interrupts the operation only when the maintenance was aborted (triggered by StopIdleMaintenance). I think we should also add the IsShuttingDown check there.
There are other places in the maintenance code, especially looping over directory entries that need these checks.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9070818 [details]
Bug 1557997 - IDB: Add more IsShuttingDown checks to database maintenance; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: Users may experience shutdown hangs caused by long running database maintenance operations.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The change is simple. We just interrupt a database maintenance operation when we are shutting down.
- String changes made/needed: None
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9070818 [details]
Bug 1557997 - IDB: Add more IsShuttingDown checks to database maintenance; r=asuth
shutdown hang prevention, approved for 68.0b10
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
Description
•