Closed Bug 1558082 Opened 5 years ago Closed 5 years ago

Port bug 1471004 - notarized macOS builds in automation

Categories

(Thunderbird :: Build Config, enhancement)

Product:
Thunderbird
Component:
Build Config
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6069+ fixed, thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 70.0
Tracking Flags:
Tracking Status
thunderbird_esr60 69+ fixed
thunderbird_esr68 68+ fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(7 files, 1 obsolete file)

signing-worker-aliases.patch
(deleted), patch
darktrojan
: review+
Details | Diff | Splinter Review
Bug 1558082 - Port bug 1471004: add notorization workerType aliases. r=aki
(deleted), text/x-phabricator-request
Details
Bug 1558082 - Port bug 1471004: move mac signing tasks to notarization/iscript pool. r=aki
(deleted), text/x-phabricator-request
Details
Bug 1558082 - Port bug 1471004: beetmove macosx pkg installer. r=aki
(deleted), text/x-phabricator-request
Details
Bug 1558082 - Port bug 1471004: add entitlements url for hardened runtime signing. r=aki
(deleted), text/x-phabricator-request
Details
Bug 1558082 - fix thunderbird scopes. r=tomprince
(deleted), text/x-phabricator-request
Details
mac_entitlements_by-release-level.patch
(deleted), patch
darktrojan
: review+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review

Notarized builds will be an Apple requirement for all software beginning with macOS 10.15.

Assignee: nobody → rob

Ported from D33856

Ported from D33857

Depends on D34634

Ported from D33858

Depends on D34635

Use an in-tree entitlements file (path is relative to $moztopsrcdir).
Use the same files as Firefox. There shouldn't be any changes needed for
Thunderbird.

Ported from D33859

Depends on D34636

Attachment #9071447 - Flags: review?(geoff) → review+
Keywords: leave-open

Ported from m-c:6487aeb66175

Attachment #9073956 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/70432a0d53dc Port bug 1471004: use worker-type aliases for signing. r=darktrojan https://hg.mozilla.org/comm-central/rev/3cfd13094036 Port bug 1471004: add notorization workerType aliases. r=aki https://hg.mozilla.org/comm-central/rev/e30f66e0e0d6 Port bug 1471004: move mac signing tasks to notarization/iscript pool. r=aki https://hg.mozilla.org/comm-central/rev/afd5ed44f8ba Port bug 1471004: beetmove macosx pkg installer. r=aki https://hg.mozilla.org/comm-central/rev/d1433086b124 Port bug 1471004: add entitlements url for hardened runtime signing. r=aki

and another errant depsigning

Should be fixed now. I canceled the graph and reran the decision task.

Flags: needinfo?(aki)
Flags: needinfo?(rob)

Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
This is being done in M-C in anticipation of an uplift to esr68. https://hg.mozilla.org/integration/autoland/rev/fa57eb4a347c
Attachment #9078480 - Flags: review?(geoff)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9078480 - Flags: review?(geoff) → review+

Does this need to land when the m-c patch does?

Flags: needinfo?(rob)
Flags: needinfo?(rob)
Keywords: checkin-needed

You mean the merge of the patch in bug 1471004 comment #31. I'll watch it.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8a97b511da21
Use by-release-level to select mac entitlements config. r=darktrojan DONTBUILD

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0

The five changesets from comment #7 and comment #15 need to go to c-esr68, right? See Mozilla uplift in bug 1471004 comment #36.

Flags: needinfo?(rob)

https://hg.mozilla.org/comm-central/rev/8a97b511da21 is on 68 and 70, but not 69 yet since bug 1471004 comment #33 isn't on m-b 69 yet.

Pieces of this need uplifting to comm-esr60 per bug 1471004 comment 46.

From C-C (they need to be applied in this order)
#1 - e30f66e0e0d6
#2 - d1433086b124
#3 - 8a97b511da21

Try job here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8f6b30a8f69c788f0377c22446bf9fabcb60d562

I'll note that some of those are failing, like the symbols upload. I believe that's because it's a try job.

Flags: needinfo?(jorgk)
Comment on attachment 9078480 [details] [diff] [review] mac_entitlements_by-release-level.patch Thanks, very pro-active. I'll take note to uplift these when I'm do the merge on m-esr60. Approved goes for two of the other patches, too, as per comment #19.
Flags: needinfo?(jorgk)
Attachment #9078480 - Flags: approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: