Closed Bug 1558124 Opened 5 years ago Closed 5 years ago

Add support for AudioWorkletNode.onprocessorerror

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla76

Tracking Flags:

Tracking

Status

firefox69

---

wontfix

firefox76

---

fixed

People

(Reporter: karlt, Assigned: padenot)

References

(Regressed 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

Bug 1558124 - Pass a JSContext to AudioWorkletGlobalScope::ConstructProcessor. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - Don't suppress the exception when the ctor of an AudioWorkletProcessor throws. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - Pass the track and the JSContext to SendProcessorError. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - When an exception happens in the AudioWorkletGlobalScope, fire `onprocessorerror`. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - Adjust WPT expectations after implementation of `AudioWorkletNode.onprocessorerror`. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - When calling the AudioWorkletProcessor ctor, switch to rethrowing exceptions to handle them manually. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - Check the type of the error passed to onprocessorerror in WPT. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details
Bug 1558124 - Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r?karlt 5 years ago Paul Adenot (:padenot) (deleted), text/x-phabricator-request		Details

Karl Tomlinson (:karlt)

Reporter

Description

•

5 years ago

https://webaudio.github.io/web-audio-api/#dom-audioworkletnode-onprocessorerror

When an exception is thrown from the processor’s constructor, process method, or any user-defined class method, the processor will queue a task on the control thread to fire onprocessorerror event to the node.

Karl Tomlinson (:karlt)

Reporter

Updated

•

5 years ago

Blocks: 1616725

Paul Adenot (:padenot)

Assignee

Updated

•

5 years ago

Assignee: nobody → padenot

Paul Adenot (:padenot)

Assignee

Comment 1

•

5 years ago

Attached file Bug 1558124 - Pass a JSContext to AudioWorkletGlobalScope::ConstructProcessor. r?karlt (deleted) — Details

Having nested AutoJSAPI clobbers the exception value of the innermost one on
destruction.

Paul Adenot (:padenot)

Assignee

Comment 2

•

5 years ago

Attached file Bug 1558124 - Don't suppress the exception when the ctor of an AudioWorkletProcessor throws. r?karlt (deleted) — Details

https://github.com/WebAudio/web-audio-api/issues/2096

Paul Adenot (:padenot)

Assignee

Comment 3

•

5 years ago

Attached file Bug 1558124 - Pass the track and the JSContext to SendProcessorError. r?karlt (deleted) — Details

Those are needed, respectively to be able to ensure the stream doesn't go away
when messaging back to the control thread, and then to access the details of the
exception thrown.

Paul Adenot (:padenot)

Assignee

Comment 4

•

5 years ago

Attached file Bug 1558124 - When an exception happens in the AudioWorkletGlobalScope, fire `onprocessorerror`. r?karlt (deleted) — Details

Paul Adenot (:padenot)

Assignee

Comment 5

•

5 years ago

Attached file Bug 1558124 - Adjust WPT expectations after implementation of `AudioWorkletNode.onprocessorerror`. r?karlt (deleted) — Details

Paul Adenot (:padenot)

Assignee

Comment 6

•

5 years ago

Attached file Bug 1558124 - When calling the AudioWorkletProcessor ctor, switch to rethrowing exceptions to handle them manually. r?karlt (deleted) — Details

Paul Adenot (:padenot)

Assignee

Comment 7

•

5 years ago

Attached file Bug 1558124 - Check the type of the error passed to onprocessorerror in WPT. r?karlt (deleted) — Details

Paul Adenot (:padenot)

Assignee

Comment 8

•

5 years ago

I don't really understand why yet, but in WPT, the file, line and column are not reported correctly.

Karl Tomlinson (:karlt)

Reporter

Updated

•

5 years ago

Blocks: 1473176

Karl Tomlinson (:karlt)

Reporter

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1623226

Karl Tomlinson (:karlt)

Reporter

Updated

•

5 years ago

Regressions: 1623230

Paul Adenot (:padenot)

Assignee

Comment 9

•

5 years ago

Attached file Bug 1558124 - Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r?karlt (obsolete) (deleted) — Details

Phabricator Automation

Comment 10

•

5 years ago

Comment on attachment 9134138 [details]
Bug 1558124 - Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r?karlt

Revision D67326 was moved to bug 1565464. Setting attachment 9134138 [details] to obsolete.

Attachment #9134138 - Attachment is obsolete: true

Pulsebot

Comment 11

•

5 years ago

Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82a790408f9b Pass a JSContext to AudioWorkletGlobalScope::ConstructProcessor. r=karlt https://hg.mozilla.org/integration/autoland/rev/23e341cbee7f Don't suppress the exception when the ctor of an AudioWorkletProcessor throws. r=karlt https://hg.mozilla.org/integration/autoland/rev/cfe8f7aab169 Pass the track and the JSContext to SendProcessorError. r=karlt https://hg.mozilla.org/integration/autoland/rev/1f8bd600d0dc When an exception happens in the AudioWorkletGlobalScope, fire `onprocessorerror`. r=karlt https://hg.mozilla.org/integration/autoland/rev/3632d18388cb Adjust WPT expectations after implementation of `AudioWorkletNode.onprocessorerror`. r=karlt https://hg.mozilla.org/integration/autoland/rev/907dd6c366e7 When calling the AudioWorkletProcessor ctor, switch to rethrowing exceptions to handle them manually. r=karlt https://hg.mozilla.org/integration/autoland/rev/c5b0bcb5bc5b Check the type of the error passed to onprocessorerror in WPT. r=karlt

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 12

•

5 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22320 for changes under testing/web-platform/tests

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 13

•

5 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Karl Tomlinson (:karlt)

Reporter

Comment 14

•

5 years ago

(In reply to Paul Adenot (:padenot) from comment #8)

I don't really understand why yet, but in WPT, the file, line and column are not reported correctly.

Bug 1623226 is the same issue.

Andreea Pavel [:apavel]

Comment 15

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/82a790408f9b
https://hg.mozilla.org/mozilla-central/rev/23e341cbee7f
https://hg.mozilla.org/mozilla-central/rev/cfe8f7aab169
https://hg.mozilla.org/mozilla-central/rev/1f8bd600d0dc
https://hg.mozilla.org/mozilla-central/rev/3632d18388cb
https://hg.mozilla.org/mozilla-central/rev/907dd6c366e7
https://hg.mozilla.org/mozilla-central/rev/c5b0bcb5bc5b

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox76: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla76

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 16

•

5 years ago

Upstream PR merged by moz-wptsync-bot

Ryan VanderMeulen [:RyanVM]

Updated

•

5 years ago

status-firefox69: affected → wontfix

You need to log in before you can comment on or make changes to this bug.