Closed Bug 1558169 Opened 5 years ago Closed 5 years ago

Task start date/time is removed upon opening the edit task dialog

Categories

(Calendar :: Dialogs, defect)

Lightning 68
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: dataloss, regression)

Attachments

(1 file, 1 obsolete file)

STR:
Switch to task tab and create a task with both start date and due date set. Save and close the task. Re-open the task for editing.

Expected:
Start date and due date are enabled and have the previously set values.

Actual:
Start date is disabled / removed.

This seems to be regressed by Bug 1551081. I reverted the following change:
'- oncommand="checkUntilDate();"
'+ onchange="checkUntilDate();"
and the tasks start date works again. Maybe checkUntilDate() gets triggered during opening the dialog and somehow breaks or modifies start date?

Regressed by: 1551081
Attached patch 1558169-item-startdate-1.diff (obsolete) (deleted) — Splinter Review

Your assessment appears to be correct, Stefan.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9072608 - Flags: review?(philipp)
Attachment #9072608 - Flags: approval-calendar-beta?(philipp)
Comment on attachment 9072608 [details] [diff] [review] 1558169-item-startdate-1.diff Try run says "no". I'll try again tomorrow.
Attachment #9072608 - Flags: review?(philipp)
Attachment #9072608 - Flags: approval-calendar-beta?(philipp)
Attached patch 1558169-item-startdate-2.diff (deleted) — Splinter Review

Take two.

Attachment #9072608 - Attachment is obsolete: true
Attachment #9072733 - Flags: review?(philipp)
Attachment #9072733 - Flags: approval-calendar-beta?(philipp)
Attachment #9072733 - Flags: review?(philipp)
Attachment #9072733 - Flags: review+
Attachment #9072733 - Flags: approval-calendar-beta?(philipp)
Attachment #9072733 - Flags: approval-calendar-beta+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/06efd8b78dc6
Fix broken start date/time in task dialog. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: