Closed Bug 1558383 Opened 5 years ago Closed 5 years ago

Double-click on Today Pane all-day event no longer opens the event dialog

Categories

(Calendar :: General, defect)

Lightning 68
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

I suspect this line in combination with bug 1531305 is to blame.

Attached patch 1558383-todaypane-doubleclick-1.diff (obsolete) (deleted) — Splinter Review

Does the job. I don't know why propagation was being stopped, but I can't see any problem with it not stopping.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9072508 - Flags: review?(philipp)
Attachment #9072508 - Flags: approval-calendar-beta?(philipp)
Attachment #9072508 - Flags: review?(philipp)
Attachment #9072508 - Flags: review+
Attachment #9072508 - Flags: approval-calendar-beta?(philipp)
Attachment #9072508 - Flags: approval-calendar-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2beda7edf8e9
Fix double-click on all-day event in Today Pane. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1

Backout:
https://hg.mozilla.org/comm-central/rev/ef63fe1ce237872810ca5209db1a1f5d55cb6ea7
Sorry, that obliterated a whole bunch of Mozmill tests.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 7.1 → ---
Attachment #9072508 - Flags: approval-calendar-beta+

Let's try that again, but this time not break double-clicking on other things. I also fixed some odd spacing that will have been caused by the same patch as this bug.

Attachment #9072508 - Attachment is obsolete: true
Attachment #9072609 - Flags: review?(philipp)
Attachment #9072609 - Flags: approval-calendar-beta?(philipp)
Attachment #9072609 - Flags: review?(philipp)
Attachment #9072609 - Flags: review+
Attachment #9072609 - Flags: approval-calendar-beta?(philipp)
Attachment #9072609 - Flags: approval-calendar-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e0cb4807daee
Fix double-click on all-day event in Today Pane. r=philipp

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: