Closed Bug 1558524 Opened 5 years ago Closed 5 years ago

Incoming mDNS candidates are ignored

Categories

(Core :: WebRTC: Signaling, defect, P2)

69 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently end up ignore incoming mDNS addresses. After they are resolved, we do not send the updated candidate to nICEr here [1] but instead pass in the original candidate with the obfuscated address.

[1] https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/media/webrtc/signaling/src/peerconnection/MediaTransportHandler.cpp#1415

Assignee: nobody → dminor
Status: NEW → ASSIGNED
Priority: -- → P2

This must have been broken while addressing review comments in Bug 1548841,
the first commit has it right and the last commit in the series breaks it.
Since we don't yet generate mDNS addresses in Firefox, the unit tests would not
catch this problem, and interoperability with other browsers would continue to
work due to peer reflex candidates.

We will have test coverage for this once we land generating our own mDNS
candidates. ICE will fail in the mochitests if we don't support resolving
mDNS addresses properly, which is how I discovered this bug.

Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/682ce4a4a4de Fix handling of incoming mDNS candidates; r=bwc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: