Closed Bug 1558968 Opened 5 years ago Closed 5 years ago

Return to AMO is broken after Bug 1548697

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- verified

People

(Reporter: rrosario, Assigned: rrosario)

References

(Regression)

Details

(Keywords: github-merged, regression)

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5107
(deleted), text/x-github-pull-request
Details
RTAMO.png
(deleted), image/png
Details

There was a typo in the patch. From @andreio on Slack: "on line asrouter-content.jsx:301 the prop name should be bundles not messages it got changed in the latest fluent version"

Iteration: --- → 69.3 - Jun 10 - 23
Blocks: 1559536

https://hg.mozilla.org/mozilla-central/rev/0dff9f803849

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED

Verified with latest Nightly on Win10x64 for the below scenarios:

  1. Force attribution from asrouter:
  • set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true, trailhead.firstrun.branches as an empty string - restart browser
  • go to about:newtab#asrouter - Targeting - Force attribution - about:welcome => the RTAMO card is displayed
  1. End-to-end flow :
  • install Firefox release from a Get Firefox button in AMO - launch browser then close it - check that the postSigningData file is created and contains the extension details - open a new Nightly profile - about:welcome => RTAMO card is displayed (more detailed steps can be found here
Status: RESOLVED → VERIFIED
Attached image RTAMO.png (deleted) —
Component: Activity Streams: Newtab → New Tab Page
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: