Use of unknown property Ci.nsIClearDataService.CLEAR_PUSH_NOTIFICATIONS
Categories
(GeckoView :: General, defect)
Tracking
(firefox67 unaffected, firefox68 wontfix, firefox69 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | unaffected |
| firefox68 | --- | wontfix |
| firefox69 | --- | fixed |
People
(Reporter: standard8, Assigned: esawin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1489669 introduced an issue in GeckoViewStorageController.jsm:
Use of unknown property Ci.nsIClearDataService.CLEAR_PUSH_NOTIFICATIONS
Looks like it should be: Ci.nsIClearDataService.CLEAR_DOM_PUSH_NOTIFICATIONS.
Bug 1489669 has been uplifted to 68, so maybe this should be as well.
It also implies the test coverage may not be sufficient (bug 1489669 comment 20 says the tests all pass, but this looks to me like when DOM_STORAGES is set, the push notifications wouldn't be cleared).
|
Assignee | |
Comment 1•5 years ago
|
||
Thanks for catching this!
The tests don't cover clearing push notifications because GeckoView doesn't support push notifications yet.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
|
||
Comment 5•5 years ago
|
||
Eugen, do we need to uplift this fix to GV 68 Beta for Fenix? Or is this "unknown property" error mostly harmless and can ride the trains in GV 69?
|
|
Assignee | |
Comment 6•5 years ago
|
||
It can ride trains, we don't support push notifications yet.
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Description
•