Closed Bug 1559355 Opened 5 years ago Closed 5 years ago

Code cleanup in about:logins

Categories

(Toolkit :: Password Manager, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(6 files)

  • Add in a <form> and use form.reset() to reset form validation
  • Pull out a reference to classList in handleEvent functions
  • Add jsdoc to methods of custom elements
  • Move custom attributes to element.dataset
  • Make method naming style consistent (_prefix vs no _prefix)
  • Order methods consistently
Flags: qe-verify-
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Attributes that are related to Fluent-based strings intentionally weren't moved to element.dataset.

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ceaec1476452 Add in a form element and use form.reset to clear form validation. r=Gijs https://hg.mozilla.org/integration/autoland/rev/e778be2565a3 Pull out a reference to classList in handleEvent. r=Gijs https://hg.mozilla.org/integration/autoland/rev/5ff49a14d8d3 Add jsdoc to public methods of custom elements. r=Gijs https://hg.mozilla.org/integration/autoland/rev/c5293d04b409 Move custom attributes to element.dataset. r=Gijs https://hg.mozilla.org/integration/autoland/rev/3172f277e311 Cache references to shadow DOM elements and move the call to reflectFluentStrings to the super-class. r=Gijs https://hg.mozilla.org/integration/autoland/rev/ea256e43a657 Add underscore prefixes to private methods. r=Gijs
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: