Allow qualified AMD devices to get WR in late beta and release
Categories
(Core :: Graphics: WebRender, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | unaffected |
| firefox67.0.1 | --- | unaffected |
| firefox68 | --- | verified |
| firefox69 | --- | verified |
People
(Reporter: pmagyari, Assigned: kats)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
[Note]
This issue does not occur on machines with Nvidia graphics cards
[Affected versions]
Firefox Beta 68.0b9
Firefox Beta 68.0b10
[Affected platforms]
Windows 10
[Steps to reproduce]
- Open browser.
- Go to about:support and check if under Graphics -> Compositing = Webrender
If it is not activated by default, go to about:config and add the following boolean: "gfx.webrender.all.qualified = true" in order to enable it - Restart the browser
[Expected result]
WebRender should be enabled.
Actual result
WebRender is not enabled.
[Additional notes]
This issue does not occur on Firefox Nightly 69.0a1.
|
||
Comment 1•5 years ago
|
||
bug 1548121 qualifies selected AMD devices only on EARLY_BETA_OR_EARLIER.
Firefox Beta 68.0b9
https://hg.mozilla.org/releases/mozilla-beta/rev/98cc1b12c5a749f5d210f92372bc9270575e57df
is included in
https://hg.mozilla.org/releases/mozilla-beta/log/FIREFOX_68_0b9_RELEASE
|
Assignee | |
Comment 2•5 years ago
|
||
I think the plan is to actually let WR for AMD to ride to release in 68, so we should drop that ifdef.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9072165 [details]
Bug 1559375 - Allow qualified AMD devices to get WR in late beta and release. r?jrmuizel
Beta/Release Uplift Approval Request
- User impact if declined: Windows users with modern AMD graphics cards won't get WR enabled in 68
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Once patch is uplifted and is in a beta build, ensure Firefox running on a modern AMD graphics card has WebRender enabled by default
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just dropping an ifndef. It was an oversight that we left this in - AMD users were getting WR enabled upto and including 68.0b8 so in terms of beta testing we only lost a couple of beta builds (b9 and b10) worth of bake time.
- String changes made/needed:
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c97ee92e2290 Allow qualified AMD devices to get WR in late beta and release. r=jrmuizel
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9072165 [details]
Bug 1559375 - Allow qualified AMD devices to get WR in late beta and release. r?jrmuizel
ship WR for some AMD devices, approved for 68.0b11
|
||
Comment 8•5 years ago
|
||
While importing this patch to uplift it for beta I ran into a conflict because the patch was based off central or at least that is my guess.
Could you please take a look?
|
|
Assignee | |
Comment 9•5 years ago
|
||
| uplift | ||
Had to rebase around bug 1556007
https://hg.mozilla.org/releases/mozilla-beta/rev/4b218aa16867e650450a8700fa45333b1903811c
|
Reporter | |
Comment 10•5 years ago
|
||
Verified fixed on Firefox Beta 68.0b11 (20190617172838) and Firefox Nightly 69.0a1 (20190617214029)
WebRender is enabled by default
Description
•