Closed
Bug 1559501
Opened 5 years ago
Closed 5 years ago
Implement icon support through setContextualTip
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: okonaraddi, Assigned: okonaraddi)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Web extensions can set and get the infobar's icon
|
||
Updated•5 years ago
|
Iteration: --- → 69.4 - Jun 24 - Jul 7
|
|
||
Updated•5 years ago
|
Iteration: 69.4 - Jun 24 - Jul 7 → 70.1 - Jul 8 - 21
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9077561 -
Attachment description: Bug 1559501 - Implement set/get icon r=mak! → Bug 1559501 - Implement set/get icon r=adw!,r=mak!
|
|
||
Updated•5 years ago
|
Attachment #9077561 -
Attachment description: Bug 1559501 - Implement set/get icon r=adw!,r=mak! → Bug 1559501 - Implement icon support and use setDefaultTip in place of individual setters/getters for icon and text elements r=adw!,mak!
|
|
||
Updated•5 years ago
|
Attachment #9077561 -
Attachment description: Bug 1559501 - Implement icon support and use setDefaultTip in place of individual setters/getters for icon and text elements r=adw!,mak! → Bug 1559501 - Implement icon support and use setContextualTip in place of individual setters/getters for icon and text elements r=adw!,mak!
|
|
Assignee | |
Updated•5 years ago
|
Iteration: 70.1 - Jul 8 - 21 → ---
Summary: Implement set/get icon → Implement icon support through setContextualTip
|
|
Assignee | |
Comment 2•5 years ago
|
||
As mentioned in Bug 1559495 Comment 1 , icon support will include setting the default, theme and various sized icons through the setContextualTip's details parameter. Currently, the contextual tip API supports setting an icon through setContextualTip and the API supports default icons of various sizes and theme icons if they're defined in the manifest as defaults. Since we're removing defaults from the manifest, web extensions should be able to provide icons for light/dark themes and high/low res screens through the browser.urlbar.contextualTip.setContextualTip function.
|
|
||
Updated•5 years ago
|
Attachment #9077561 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Iteration: --- → 70.2 - Jul 22 - Aug 4
|
|
||
Updated•5 years ago
|
Attachment #9081510 -
Attachment description: Bug 1559501 - Implement icon support through setContextualTip r=adw!,mak!,mixedpuppy! → Bug 1559501 - Implement icon support through setContextualTip r=adw!,mixedpuppy!
|
|
||
Updated•5 years ago
|
Attachment #9081510 -
Attachment description: Bug 1559501 - Implement icon support through setContextualTip r=adw!,mixedpuppy! → Bug 1559501 - Implement icon support through setContextualTip r=adw!
Pushed by okonaraddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3939226182e9
Implement icon support through setContextualTip r=adw,mixedpuppy
|
|
Assignee | |
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•5 years ago
|
Status: REOPENED → ASSIGNED
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•