Closed Bug 1559556 Opened 5 years ago Closed 5 years ago

GL<440 Can't rely on BlitFramebuffer to sRGB encode/decode

Categories

(Core :: Graphics: CanvasWebGL, defect, P2)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 2 open bugs,
URL
)

Details

Attachments

(1 file)

Bug 1559556 - Handle sRGB encode/decode BlitFramebuffer calls on GL<440.
(deleted), text/x-phabricator-request
Details

Here's Chromium's handling:
https://cs.chromium.org/chromium/src/third_party/angle/src/libANGLE/renderer/gl/FramebufferGL.cpp?sq=package:chromium&dr=C&g=0

Decode sRGB->linear requires GL440.
Encode linear->sRGB requires GL420.

This repros most obviously on Mac, which only supports GL410. (suspicious!)

Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d768efa49870 Handle sRGB encode/decode BlitFramebuffer calls on GL<440. r=lsalzman

https://hg.mozilla.org/mozilla-central/rev/d768efa49870

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: