Make Font Editor handle keyword values for line-height
Categories
(DevTools :: Inspector, task, P1)
Tracking
(firefox69 fixed)
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With fixing bug 1536871, the new default value for line-height from getComputedStyle() becomes "normal", not a numeric value.
The Font Editor expects to always be able to parseFloat() the line-height value into a number and that fails resulting in a crashed Font Editor and failed tests.
Similarly to how letter-spacing accepts keyword values, we should ensure components handling line-height follow suit.
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
Thanks for taking this Razvan!
|
||
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Remove default conversion for line-height value to unitless value to prevent Font Editor from crashing when the patch from Bug 1536871 (the default computed value for line-heightis no longer numeric).
Adds support for normal keyword value for line-height as the default returned by getComputedStyle(), similar to existing behavior for letter-spacing.
Fixes misnomer of the class in LetterSpacing.js component.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•