Closed Bug 1560168 Opened 5 years ago Closed 5 years ago

antenna should ignore querystring params

Categories

(Socorro :: Antenna, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

Attachments

(2 files)

In bug #1420363, we're trying to put all the annotations in a single JSON-serialized value so then we'd have an "extra" field and zero or more minidump fields. Antenna has a check where it gets fussy if there's an "extra" field and also one or more non-minidump fields.

It seems like that's not working right. The check is probably fine, but either cgi.FieldStorage is spitting out fields that don't exist or something I'm not imaginative to come up with.

This bug covers adding some logging and stuff to figure that out and then eradicating the problem.

Type: task → defect
Priority: -- → P2
Assignee: nobody → willkg

We figured out what's going on. Antenna's cgi.FieldStorage usage is pulling both the HTTP POST payload as well as the querystring params. We don't care about the querystirng params--we want to ignore them.

So this bug covers fixing it to ignore querystring params correctly.

Summary: might be parsing nonexistent fields in crash payload → antenna should ignore querystring params

I verified this fixes the issue in stage. I'll deploy this to prod on Monday.

This is in prod now. Marking as FIXED.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: