Fix WPT background-image-first-line.html to specify a line-height
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This WPT test currently fails:
http://w3c-test.org/css/css-backgrounds/background-image-first-line.html
http://w3c-test.org/css/css-backgrounds/reference/background-image-first-line-ref.html
...because the testcase puts the background on a ::first-line selector, and the line-height is left at its default value normal, which for us means ~1.2em which gives the div a height of 120px and the line is offset by 10px.
We should fix the test to avoid this accidental dependency on line-height:normal behavior, by specifying line-height:1 as part of the font declaration in this testcase/reference case.
|
Assignee | |
Comment 1•5 years ago
|
||
This matches the recommendation at:
https://web-platform-tests.org/writing-tests/ahem.html
...and it makes this test start passing. Without this change, the default
line-height:normal behavior effectively behaves like line-height:1.2 in
Firefox, which creates some space between the content and the container's top
border, which makes the test fail.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Description
•