Closed
Bug 1560294
Opened 5 years ago
Closed 5 years ago
Relax the assertion against `frameId` argument in Page.navigate
Categories
(Remote Protocol :: CDP, task)
Remote Protocol
CDP
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This assertion in Page.navigate:
async navigate({url, referrer, transitionType, frameId} = {}) {
if (frameId) {
throw new UnsupportedError("frameId not supported");
}
Makes many puppeteer tests to fail as latest puppeteer versions always pass a frameId
attribute, even for the top level tab document.
But this assertion was mostly meant to warn about this being unimplemented when you were trying to target an iframe. If frameId refers to the top level tab document, that is fine. This method will work as expected.
So we can refine this check in order to let it pass and keep iframe support for a followup.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/113fbb51b177
Relax frameId check in Page.navigate. r=remote-protocol-reviewers,ato
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Component: CDP: Page → CDP
You need to log in
before you can comment on or make changes to this bug.
Description
•