Closed Bug 1560294 Opened 5 years ago Closed 5 years ago

Relax the assertion against `frameId` argument in Page.navigate

Categories

(Remote Protocol :: CDP, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This assertion in Page.navigate:

  async navigate({url, referrer, transitionType, frameId} = {}) {
    if (frameId) {
      throw new UnsupportedError("frameId not supported");
    }

Makes many puppeteer tests to fail as latest puppeteer versions always pass a frameId attribute, even for the top level tab document.
But this assertion was mostly meant to warn about this being unimplemented when you were trying to target an iframe. If frameId refers to the top level tab document, that is fine. This method will work as expected.

So we can refine this check in order to let it pass and keep iframe support for a followup.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/113fbb51b177 Relax frameId check in Page.navigate. r=remote-protocol-reviewers,ato
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: CDP: Page → CDP
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: