Closed Bug 1560312 Opened 5 years ago Closed 5 years ago

Make the fission subtests for browser_test_group_fission work on non-WR

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Fission Milestone M4
Tracking Status
firefox70 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

In bug 1559259 :rhunt added a fix for the APZ/fission hit-testing codepath for non-WR. This should have made all the subtests pass without WebRender, but for some reason they were still failing (see e.g. bug 1559565). We should figure out why and fix it.

One possible reason is that the OOP iframe doesn't get a displayport and so APZ doesn't have a layers id for it. That is, the rectangle is just in the dispatch-to-content region for the top-level content document. If that's the case then we can probably modify the test to force setting a displayport. But it might also get fixed by bug 1541589.

I moved the tests to run on non-WR as well and ran with --verify a few times on local Windows and Linux builds, and it seems to pass perfectly fine. Maybe something else fixed it along the way.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e5ef0cc26d00c4db843c364d25e0a452b713e270

Try push shows it failing on windows 7 but passing on linux and windows 10 (and macOS). So maybe we can just disable the test on win7 and move the subtests unconditionally.

There isn't a mochitest condition for "win7" specifically, but it's the only windows 32-bit platform, so we can condition on that. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=6bbdeebb26d6f125b7734e83637fb1d2d8626021

Assignee: nobody → kats

This also disables the test on Windows 7 because the newly enabled subtests
fail intermittently there. We don't care so much about Windows 7 these days,
and I don't have a local setup to reproduce it, so I didn't investigate the
failure.

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddd8910e7d83 Run fission tests without WR as well. r=botond
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: