Firefox account menu item is misaligned on the right side when signed in
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox67 | --- | unaffected |
| firefox67.0.1 | --- | unaffected |
| firefox68 | --- | verified |
| firefox69 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Regression)
Details
(Keywords: polish, regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
ritu
:
approval-mozilla-beta+
|
Details |
+++ This bug was initially created as a clone of Bug #1383535 +++
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Can you explain the summary? What is "misaligned", in what way, on what OS?
|
|
Assignee | |
Comment 3•5 years ago
|
||
All OSes, I think, at least I've seen this on Windows and Linux, and the code is shared across platforms. It basically looks like the screenshot in bug 1383535 comment 0.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #3)
It basically looks like the screenshot in bug 1383535 comment 0.
Actually it's slightly worse than that, as not only the hover background is affected; the arrow is too far to the left even without hover.
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Fixed on latest Nightly.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Comment on attachment 9073025 [details]
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs
Beta/Release Uplift Approval Request
- User impact if declined: Firefox account menu item looks off
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): trivial fix
- String changes made/needed:
Comment on attachment 9073025 [details]
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs
low-risk CSS only fix, beta68+
|
||
Comment 10•5 years ago
|
||
| bugherder uplift | ||
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 11•5 years ago
|
||
I have reproduced this issue using Firefox 69.0a1 (2019.06.20) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0b13 on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.13.6.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•3 years ago
|
Description
•