Closed
Bug 1560447
Opened 5 years ago
Closed 5 years ago
about:logins is slow to display all the login count is greater than 100
Categories
(Firefox :: about:logins, defect, P3)
Firefox
about:logins
Tracking
()
RESOLVED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Keywords: perf, Whiteboard: [passwords:management] [skyline] )
Attachments
(2 files)
Profiling shows that 69% of the time is spent in crypto-SDR.js' decrypt method. We should try implementing a batch decryption method analogous to encryptMany and see if this fixes enough of the performance hit.
Flags: qe-verify-
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
Profile showing performance issue: https://perfht.ml/2X2VemI
|
|
Assignee | |
Comment 2•5 years ago
|
||
@keeler, the last test case is failing and I believe it is an encoding issue but I'm not comfortable enough with this code. Can you help me out here?
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Profile showing performance improvement of patch: https://perfht.ml/2X3svhK
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c2f7d75146b
Add a decryptMany method to crypto-SDR.js for batch decrypting of stored logins. r=keeler
https://hg.mozilla.org/integration/autoland/rev/e0311539d0fb
Add a getAllLoginsAsync method to LoginManager and call it from about:logins. r=mossop
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0c2f7d75146b
https://hg.mozilla.org/mozilla-central/rev/e0311539d0fb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
||
Updated•5 years ago
|
Whiteboard: [passwords:management] [skyline]
|
||
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
Version: unspecified → Trunk
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•