Handle errors properly in about:certificate
Categories
(Firefox :: Security, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: carolina.jimenez.g, Assigned: carolina.jimenez.g, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In AboutCertViewerHandler
we can send an error message if something is wrong and we cannot send the certificate to about:certificate
, this could be done with something like this:
aMessage.target.sendAsyncMessage("Error", {
err: "There was an error",
});
And in the page, we can receive the error doing:
document.addEventListener("DOMContentLoaded", (e) => {
RPMAddMessageListener("Error", showError);
});
function showError(message) {
console.log("error ", message.data.err);
}
We need to handle all possible errors and show it in another way rather than console logging to the user.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
This will probably need some coordination with Danielle to make sure we show some kind of UI to the user.
Assignee | ||
Comment 2•5 years ago
|
||
Maybe you can file a bug about creating the UI for errors? That way I can add here that bug blocking this one
Thanks
Comment 3•5 years ago
|
||
For the UI for errors, I'm currently creating a component that would conditionally render if there was an error.
That component would take up the full browser window, and would display an error message and image.
Should specific information about the error be displayed, or just a general 'error' message?
The call to create it could come from the "DOMContentLoaded"
event listener in certviewer.js
based on the response from RPMSendAsyncMessage("getCertificate");
(if I'm understanding that function correctly).
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to danielleleb12 from comment #3)
Should specific information about the error be displayed, or just a general 'error' message?
I'm not sure yet, maybe we should ask Johann, but for the moment it could be a general error message, in my opinion.
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/014889dc7434
Handles errors in about:certificate.r=keeler
Comment 8•5 years ago
|
||
bugherder |
Comment 9•5 years ago
|
||
Backed out for causing high failure rate in Bug 1567161.
https://hg.mozilla.org/integration/autoland/rev/c5c6af9140705cc3d2b50352cc3d1f97da89bc32
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b073b95fcf61
Handles errors in about:certificate.r=keeler
Comment 12•5 years ago
|
||
bugherder |
Description
•