Set a maxVersion of 69 for Lockwise extension and update the description to tell users the feature is built-in now
Categories
(Firefox :: about:logins, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | verified |
People
(Reporter: jaws, Assigned: m_and_m)
References
Details
(Whiteboard: [passwords:management] [skyline])
We're planning on shipping Lockwise built-in to Firefox in 70, and thus the Lockwise extension will be obsolete. We should set the maxVersion of the extension to 69 so it will disable itself automatically, then we can have the extension uninstall itself or update the description to explain that the extension is now built-in to Firefox.
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Matthew, is this something you can help out with?
Assignee | ||
Comment 3•5 years ago
|
||
Yes, I can help out. I should be able to have a PR in that repo up by the start of next week.
If we can update https://github.com/mozilla-lockwise/lockwise-addon/issues/188 with this directly, that would help.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Matthew, are you still working on this ? Or do you already have a patch?
Assignee | ||
Comment 5•5 years ago
|
||
This has been patched:
- add-on manifest: https://github.com/mozilla-lockwise/lockwise-addon/pull/334
- updates manifest: https://github.com/mozilla-lockwise/mozilla-lockwise.github.io/pull/138
- Add-on release: https://github.com/mozilla-lockwise/lockwise-addon/pull/338
- Add-on deployment: https://github.com/mozilla-lockwise/mozilla-lockwise.github.io/pull/140
Great, want to close the bug? Or, is there anything left to do here?
Assignee | ||
Comment 7•5 years ago
|
||
I think we can close it; will do so now.
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
I have verified this issue on Firefox Beta 70.0b3 and the latest Nightly 71.0a1 build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.
- The Lockwsie extension is successfully disabled after updating the Nightly 69.0a1 build to Nightly 70.0a1. Also, the "feature is built-in Firefox" message is correctly displayed in "about:addons" on the disabled Lockwise extension.
- The Lockwsie extension is successfully disabled after updating the Firefox Beta 69.0bx to Beta 70.0b3. Also, the "feature is built-in Firefox" message is correctly displayed in "about:addons" on the disabled Lockwise extension.
Updated•5 years ago
|
Description
•