Closed Bug 1560689 Opened 5 years ago Closed 5 years ago

Remove react-intl dependencies and script loading

Categories

(Firefox :: New Tab Page, task, P1)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5148
(deleted), text/x-github-pull-request
Details
Bug 1560689 - Remove react-intl dependencies and script loading
(deleted), text/x-phabricator-request
Details

Once we don't import react-intl, we can remove:

  • the vendored dependency and license files
  • package.json dependency entry
  • script loading from aboutNewTabService and html prerendering
Priority: -- → P1

It can also be removed from bin/vendor.js

The actual package.json dependency can't be removed until we remove all uses, e.g., bug 1556888 for tests and whatever lingering unnecessary injectIntl related calls.

Depends on: 1556888
Depends on: 1561208
Assignee: nobody → edilee
Component: Activity Streams: Newtab → New Tab Page

Depends on D36764

Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c61360a73028 Remove react-intl dependencies and script loading r=dmose

https://hg.mozilla.org/mozilla-central/rev/c61360a73028

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: