Closed
Bug 1560707
Opened 5 years ago
Closed 5 years ago
Typo in header of class MozMailMultiEmailheaderfield
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: joachim.herb, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
The header of class MozMailMultiEmailheaderfield reads:
/**
- The mail-multiemail-headerfield widgets shows multiple emails. It collapses long rows and allows
- toggling the full view open. This widget is typically used in the message header pane to show
- addresses for To, Cc, Bcc, and any other addressing type header that can contain more than one
- mailbox.
- extends {MozXULElement}
*/
But it acutally binds the XUL element mail-multi-emailheaderfield
So the second dash is placed wrong.
Also it would make life easier for addon developers if the renaming would be mentioned at https://developer.thunderbird.net/add-ons/tb68/changes
|
Assignee | |
Comment 1•5 years ago
|
||
Assignee: nobody → mkmelin+mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9073387 -
Flags: review?(jorgk)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9073387 [details] [diff] [review]
bug1560707_multiemail-typo.patch
I don't think a comment change needs review :-)
Attachment #9073387 -
Flags: review?(jorgk) → review+
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed
|
Reporter | |
Comment 3•5 years ago
|
||
Actually, should the class name be in the comment or the XUL tag type it is bound to?
|
|
Assignee | |
Comment 4•5 years ago
|
||
Usually we've put the class name. I don't think there's a rule.
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 69.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e2aac84cae94
fix typo in the documentation of MozMailMultiEmailheaderfield. r=jorgk DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•