Closed Bug 1561005 Opened 5 years ago Closed 5 years ago

Network ID: add nsINetworkLinkService.networkID

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla69

Tracking Flags:

Tracking

Status

firefox69

---

fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(5 files)

Bug 1561005 - Add nsINetworkLinkService.networkID r=mayhemer,michal 5 years ago Valentin Gosu [:valentin] (he/him) (deleted), text/x-phabricator-request		Details
Bug 1561005 - Make windows networkID use the INetworkListManager API r=mayhemer,michal 5 years ago Valentin Gosu [:valentin] (he/him) (deleted), text/x-phabricator-request		Details
Bug 1561005 - Implement nsINetworkLinkService.networkID on Linux r=michal 5 years ago Valentin Gosu [:valentin] (he/him) (deleted), text/x-phabricator-request		Details
Bug 1561005 - Implement nsINetworkLinkService.networkID on mac r=michal 5 years ago Valentin Gosu [:valentin] (he/him) (deleted), text/x-phabricator-request		Details
Bug 1561005 - Add empty GetNetworkID impl for Android r=michal 5 years ago Valentin Gosu [:valentin] (he/him) (deleted), text/x-phabricator-request		Details

Valentin Gosu [:valentin] (he/him)

Assignee

Description

•

5 years ago

No description provided.

Valentin Gosu [:valentin] (he/him)

Assignee

Comment 1

•

5 years ago

Attached file Bug 1561005 - Add nsINetworkLinkService.networkID r=mayhemer,michal (deleted) — Details

Valentin Gosu [:valentin] (he/him)

Assignee

Comment 2

•

5 years ago

Attached file Bug 1561005 - Make windows networkID use the INetworkListManager API r=mayhemer,michal (deleted) — Details

Depends on D35683

Valentin Gosu [:valentin] (he/him)

Assignee

Comment 3

•

5 years ago

Attached file Bug 1561005 - Implement nsINetworkLinkService.networkID on Linux r=michal (deleted) — Details

calculateNetworkId is now called before sending each ChangeEvent
mNetworkId is truncated when no IPv4/IPv6 IDs could be computed

Depends on D35684

Valentin Gosu [:valentin] (he/him)

Assignee

Comment 4

•

5 years ago

Attached file Bug 1561005 - Implement nsINetworkLinkService.networkID on mac r=michal (deleted) — Details

Depends on D35780

BugBot [:suhaib / :marco/ :calixte]

Comment 5

•

5 years ago

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement

Valentin Gosu [:valentin] (he/him)

Assignee

Comment 6

•

5 years ago

Attached file Bug 1561005 - Add empty GetNetworkID impl for Android r=michal (deleted) — Details

Depends on D35781

Shane Caraveo (:mixedpuppy)

Updated

•

5 years ago

Blocks: 1550605

Valentin Gosu [:valentin] (he/him)

Assignee

Updated

•

5 years ago

Blocks: 1561944

Pulsebot

Comment 7

•

5 years ago

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6b3b29de9c78 Add nsINetworkLinkService.networkID r=michal https://hg.mozilla.org/integration/autoland/rev/82eeb4c5e535 Make windows networkID use the INetworkListManager API r=michal https://hg.mozilla.org/integration/autoland/rev/5c33e521c0e8 Implement nsINetworkLinkService.networkID on Linux r=michal https://hg.mozilla.org/integration/autoland/rev/61cf9ae8abcf Implement nsINetworkLinkService.networkID on mac r=michal https://hg.mozilla.org/integration/autoland/rev/c552aeab0fbf Add empty GetNetworkID impl for Android r=michal

Alexandru Michis [:malexandru]

Comment 8

•

5 years ago

Backed out 5 changesets for causing bustages in nsNetworkLinkService and nsNotifyAddrListener.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/8537d24d8aa8c0c2189c308d5835def2feec313c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c552aeab0fbfa729d61467f507b8a117da77e524&selectedJob=253898337

Failures:

at nsNetworkLinkService: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253898307&repo=autoland&lineNumber=13913
at nsNotifyAddrListener.cpp: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253898295&repo=autoland&lineNumber=54677

Flags: needinfo?(valentin.gosu)

Pulsebot

Comment 9

•

5 years ago

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/816fc698fef5 Add nsINetworkLinkService.networkID r=michal https://hg.mozilla.org/integration/autoland/rev/fe5083dd21d9 Make windows networkID use the INetworkListManager API r=mayhemer,michal https://hg.mozilla.org/integration/autoland/rev/958ba48a629f Implement nsINetworkLinkService.networkID on Linux r=michal https://hg.mozilla.org/integration/autoland/rev/ea28e757a7b6 Implement nsINetworkLinkService.networkID on mac r=michal https://hg.mozilla.org/integration/autoland/rev/6e10a31d6608 Add empty GetNetworkID impl for Android r=michal

Valentin Gosu [:valentin] (he/him)

Assignee

Updated

•

5 years ago

Flags: needinfo?(valentin.gosu)

Stefan Hindli [:stefan_hindli]

Comment 10

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/816fc698fef5
https://hg.mozilla.org/mozilla-central/rev/fe5083dd21d9
https://hg.mozilla.org/mozilla-central/rev/958ba48a629f
https://hg.mozilla.org/mozilla-central/rev/ea28e757a7b6
https://hg.mozilla.org/mozilla-central/rev/6e10a31d6608

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox69: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla69

Nhi Nguyen (:nhi)

Updated

•

5 years ago

Blocks: secure-proxy

Nhi Nguyen (:nhi)

Updated

•

5 years ago

No longer blocks: 1561944

Michal Novotny [:michal]

Updated

•

5 years ago

Regressions: 1576386

Valentin Gosu [:valentin] (he/him)

Assignee

Updated

•

5 years ago

Blocks: 1580130

You need to log in before you can comment on or make changes to this bug.