Closed Bug 1561447 Opened 5 years ago Closed 5 years ago

CSS drop-shadow filter clips shadow with a rotate transform

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- disabled
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: cbrewster, Assigned: cbrewster)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: correctness, regression)

Attachments

(4 files)

Attached file Test case (deleted) —

When a transform is applied to an element with a CSS drop-shadow filter applied, the shadow can be clipped.

This only happens when the blur radius is relatively small, but this likely means there are some issues around inflating a picture's surface rect when a drop-shadow filter is applied.

Attached image FF Nightly 69 - WebRender Enabled (deleted) —
Attached image FF 67.0.2 - WebRender Disabled (deleted) —
Attachment #9074000 - Attachment mime type: text/plain → text/html

mozregression --good 2018-08-15 --bad 2018-09-15 --pref gfx.webrender.all:true -a https://bug1561447.bmoattachments.org/attachment.cgi?id=9074000

8:54.99 INFO: Last good revision: febddb5a4dc21c7b09b02efc39568a03588d893b
8:54.99 INFO: First bad revision: 0192efea1b664db8d20a691401ec5d3f9d3a2122
8:54.99 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=febddb5a4dc21c7b09b02efc39568a03588d893b&tochange=0192efea1b664db8d20a691401ec5d3f9d3a2122

Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1459065

The same statement might apply here:

(Emilio Cobos Álvarez (:emilio) from bug 1514384 comment 2)

Well, sure, before that we wouldn't clip it at all :)

Priority: -- → P3
OS: Unspecified → All
Hardware: Unspecified → All

This problem only occurs when the square is partly off the page, in this case a clip task is created which gets applied to the square's shadow. If the square is entirely in the page, no clip task is created and the shadow is properly rendered.

As far as I can tell, this is an issue inside WebRender as there isn't a clip in the display list itself that would cause this.

Also as the blur radius increases, the clip rect seems to increase as well, so we are probably taking the blur radius into account without considering the offset.

Assignee: nobody → cbrewster
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c1def596e46
Include picture shadow in local rect when building clip chain r=nical

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Given that we're less than a week from Fx69 RC, I think we can let this fix ride Fx70 to release. Feel free to nominate for Beta approval if you feel strongly otherwise.

Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: