Closed
Bug 1561577
Opened 5 years ago
Closed 5 years ago
Hitting the Escape key to close the shortcuts modal also toggles the Split Console
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox69 fixed)
RESOLVED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: fvsch, Assigned: arosenfeld2003)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We added the ability to close the Shortcuts modal with the Escape key to be consistent with other modal UI in Debugger, but it was probably not tested in a Firefox build.
Steps to reproduce:
- In Firefox Nightly, open the Debugger
- On the Welcome page, click "Show all shortcuts"
- Hit the Escape key
Expected result:
- The shortcuts modal is closed
Actual result:
- The shortcuts modal is closed
- The Split Console is toggled
We should probably stop the event's propagation or something similar.
|
||
Comment 1•5 years ago
|
||
Yes. This is a regression. We are really careful with escape because it is context specific.
|
|
||
Updated•5 years ago
|
Blocks: dbg-frontend
Keywords: good-first-bug
|
|
||
Updated•5 years ago
|
Priority: -- → P3
I think I've got a quick one-line fix for this... I'll go ahead and submit a patch for review.
Prevent toggling open Split Console with escape is pressed to toggle shortcutsModal closed.
|
||
Updated•5 years ago
|
Assignee: nobody → arosenfeld2003
Status: NEW → ASSIGNED
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33eca9689b58
prevent default when esc is pressed on shortcutsModal r=jlast
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in
before you can comment on or make changes to this bug.
Description
•