Open Bug 1561647 Opened 5 years ago Updated 2 years ago

"View Saved Logins" at the end of the scroll-list when more than 5 logins saved

Categories

(Toolkit :: Password Manager, defect, P3)

69 Branch
defect

Tracking

()

Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox67 --- affected
firefox68 --- affected
firefox69 --- affected

People

(Reporter: okazki98, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Attached video 2019.06.26-18.57_02.mp4 (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

  1. Go to a page with a Log In form
  2. Save multiple logins for this page, until the saved logins list becomes scrollable
  3. Open the saved logins list.

Actual results:

"View saved logins" is hidden unless the user scrolls through the whole list.

Expected results:

"View saved logins" should have a fixed position at the bottom boundary of the saved logins list box.

Managed to reproduce this issue on Firefox Nightly 69.0a1, Firefox 68.0b14 and Firefox 67.0.4 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: UNCONFIRMED → NEW
Component: Untriaged → Password Manager
Ever confirmed: true
Product: Firefox → Toolkit

A workaround would be bump the minimum shown from 6 like we did for address autofill.

Priority: -- → P3
Summary: "View Saved Logins" at the end of the scroll-list when multiple logins are saved → "View Saved Logins" at the end of the scroll-list when more than 5 logins saved
Blocks: 1189618
Priority: P3 → P2

(Quoting dana from bug 1329903 comment #6)

I had originally submitted bug 1590622 to complain about this, though it was ultimately repurposed to address another issue. Since this one already exists i won't make another, but i will mention the following:

  • The lack of a height restriction causes the drop-down to, in some cases, span an almost comically large vertical space — i.e., from where-ever the form element is to the very top or bottom of the screen. Aside from being generally unsightly, this blocks out a lot of content on the page as well as any windows beneath the browser window, which can be a frustrating experience when you're trying to read something.

  • It was mentioned that it might not be a common thing to have lots of saved log-ins for a single domain. Now that log-ins for sub-domains are included in the drop-down, i think it'll come up more often. It's especially problematic in the case of internal company networks, where you'll often have a million different Web applications under one domain (analytics.example.com, docker.example.com, git.example.com, mail.example.com, timekeeping.example.com, &c.). That was the scenario i ran into.

Do all those domains actually have different credentials? Or do you have some that are stale? We dedupe results that have the same username+password combo. At many companies LDAP or ActiveDirectory are used so you generally only have one username+password combo for primary account (then maybe a few others for service accounts).

That's true about LDAP, i didn't consider that. Unfortunately the company i work for is not so well organised yet. :/

Re: different credentials, i think all of the ones i see in my drop-down are unique user+pass combinations. There are definitely a few that look stale (they show HTTP basic-auth realms that have long since been changed), but if i removed those i'm sure others would replace them. In my case, a decent percentage of the saved log-ins are for different test instances of our product — so, on balance, given that and the LDAP/SSO point you mentioned, i might have overstated how common my situation is....

Thanks for following me through all of this.

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Keywords: regression
Blocks: 1601558

Btw. I looked into this again to see if it was straightforward but of course it's not… keeping the footer as one of the results helps with consistent keyboard navigation using up/down/page up/page down keys but then it's not just as simple as using position: sticky since there isn't a way to easily scroll the selected richlistitem into view which takes the sticky footer into account… we would have to do special handling for the footer, I guess with a subclass.

Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: