Flash plugin's `File` and `MIME Types` fields are empty in HTML about:addons
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | verified |
firefox67 | --- | unaffected |
firefox67.0.1 | --- | unaffected |
firefox68 | + | verified |
firefox69 | --- | verified |
People
(Reporter: cpeterson, Assigned: robwu)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release+
jcristau
:
approval-mozilla-esr68+
|
Details |
(deleted),
text/x-phabricator-request
|
Details |
[Tracking Requested - why for this release]:
This bug is a regression in Firefox 68 from bug 1555012.
Steps to reproduce
- Open about:addons.
- Click "Plugins".
- Click "Shockwave Flash".
- Click "Options".
Expected results
The File
field's value should be something like NPSWF64_32_0_0_207.dll
. The MIME Types
field's value should be application/x-shockwave-flash (Adobe Flash movie: swf), application/futuresplash (FutureSplash movie: spl)
.
Actual results
The File
and MIME Types
fields have no values. See the attached screenshot.
Assignee | ||
Comment 2•5 years ago
|
||
Patch incoming.
Assignee | ||
Comment 3•5 years ago
|
||
The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.
Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/5d560c5e357d Move pluginPrefs initialization to pluginPrefs.js r=Gijs
Comment 5•5 years ago
|
||
bugherder |
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9074495 [details]
Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js
Beta/Release Uplift Approval Request
- User impact if declined: The "File" and "MIME types" rows of the flash plugin are empty instead of showing the expected metadata.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch moves around existing code and includes a unit test that verifies the expected behavior.
- String changes made/needed: none
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Comment on attachment 9074495 [details]
Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js
HTML about:addons fix for plugin prefs, approved for 68 rc1
Comment 8•5 years ago
|
||
bugherder uplift |
Comment 9•5 years ago
|
||
bugherder uplift |
Comment 10•5 years ago
|
||
Backed out because isFlashPlugin needs to be a method of a plugin in the new code but it's a function of PluginProvider.jsm (conflict with bug 1519434):
https://hg.mozilla.org/releases/mozilla-release/rev/2d818026aa0b85ce91d0cbd401d7833961408f55
https://hg.mozilla.org/releases/mozilla-esr68/rev/8e3d59d881261610fb366644dad874080d889a40
Assignee | ||
Comment 11•5 years ago
|
||
The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.
Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.
Assignee | ||
Comment 13•5 years ago
|
||
uplift |
Updated•5 years ago
|
Comment 14•5 years ago
|
||
Verified as fixed in FF 68.0 and 69.0a1 (2019-07-02) on Win10x64 and macOS 10.13.6
The File field's value on macOS is "Flash Player.plugin" instead of something something like "NPSWF64_32_0_0_207.dll" how is for Windows.
Please let me know if this is the expected behavior.
Assignee | ||
Comment 15•5 years ago
|
||
(n reply to Victor Carciu from comment #14)
The File field's value on macOS is "Flash Player.plugin" instead of something something like "NPSWF64_32_0_0_207.dll" how is for Windows.
Please let me know if this is the expected behavior.
Looks good to me.
Comment 16•5 years ago
|
||
Verified as fixed also in 68.0esr (64-bit) on Win10x64 and macOS 10.13.6
Updated•5 years ago
|
Updated•5 years ago
|
Updated•3 years ago
|
Description
•