Update the strings of animation warnings for transform-like properties
Categories
(Core :: CSS Transitions and Animations, enhancement, P3)
Tracking
()
People
(Reporter: boris, Unassigned)
References
(Blocks 1 open bug)
Details
We still use transform
property in animation warning strings [1], but it's not correct because it may be caused by other transform-like properties, so we should replace "Animations of ‘transform’" with "Transform-related animations" or even just "Transform animations".
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?
Comment 2•5 years ago
|
||
Anyways, if we change the strings we also need to change the symbols (i.e. CompositorAnimationWarningTransformSVG), IIRC.
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?
Yes, but Brian suggested it'd be better to use a more precise word to express this when reviewing the patches, so I filed this bug. Either way is ok to me actually.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 4•5 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
IIRC, we discussed about the strings when I reviewed some of patches for individual transform property animations, and we agreed that we use the strings as they are, no?
I checked the implementation again and we use transform property set for these warnings in most cases, so it becomes pretty hard to set the warning for a specific property name. For example, it might be a combination of part of transform-like properties, so we should use a general word for them. After introducing motion-path, we probably need to update the string to something like "transform or motion" properties. So for now, I prefer to not updating the string and not blocking ship bug.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•2 years ago
|
Description
•