Be more mindful of how much memory we touch during nursery poisoning.
Categories
(Core :: JavaScript: GC, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
(Blocks 1 open bug)
Details
(Keywords: memory-footprint, perf)
Attachments
(5 files, 1 obsolete file)
When the nursery is initalised we poison the entire nursery chunk with the initalisation pattern. Although poisoning is only used during testing and on Nightly, this will affect the memory usage telemetry we're seeing from Nightly. Let's avoid touching that memory so we get telemetry that represents better what we'll achieve in release.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
I've made Bug 1562551 a duplicate and will also fix another case of over-poisoning with this bug.
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
This poisoning happens eventually when the chunk is decommitted, but it's
important to do it synchronously to catch more bugs. Unlike the other
patches on this bug this one increases the amount of poisoning done.
Depends on D36876
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
When we shrink the nursery below one chunk, poison and mark as inaccessible
the now unused part of that chunk.
This is the only patch in this patch series that adds extra memory poisoning.
Depends on D36876
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c274e3d473b (part 1) Add a poisonRange method to NurseryChunk r=jonco https://hg.mozilla.org/integration/autoland/rev/111838e2b22f (part 2) Don't poison memory unnecessarily during Nursery::init r=jonco https://hg.mozilla.org/integration/autoland/rev/0e662f79db6c (part 3) Poison unused memory when we shrink the nursery r=jonco https://hg.mozilla.org/integration/autoland/rev/89feefb6541e (part 4) We don't need to poison the start chunk here r=jonco https://hg.mozilla.org/integration/autoland/rev/6cc26a5b9fe2 (part 5) Avoid unnecessary poisoning between GCs r=jonco
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9c274e3d473b
https://hg.mozilla.org/mozilla-central/rev/111838e2b22f
https://hg.mozilla.org/mozilla-central/rev/0e662f79db6c
https://hg.mozilla.org/mozilla-central/rev/89feefb6541e
https://hg.mozilla.org/mozilla-central/rev/6cc26a5b9fe2
Description
•