Fix some minor baseline interpreter issues
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(5 files)
Patches for a few minor issues exposed by enabling for jit-tests on Try.
Assignee | ||
Comment 1•5 years ago
|
||
It needs to set resumePCinCurrentFrame_ to an address in the interpreter JitCode
instead of nullptr (or else the profiler's JitCodeMap lookup will assert).
Assignee | ||
Comment 2•5 years ago
|
||
This avoids overrecursion exceptions on testManyVars.js on Windows/Linux
(the C++ interpreter has heap-allocated stack frames so it can handle this
better).
Depends on D36468
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D36469
Assignee | ||
Comment 4•5 years ago
|
||
This is process-wide state and storing it in JSContext/JSRuntime requires
callers to pass a context/runtime for no good reason. This simplifies the
next patch.
Storing this in JitOptions seemed nicer than adding new globals for this and
maybe in the future we will have a testing function/flag to toggle these
flags.
Depends on D36470
Assignee | ||
Comment 5•5 years ago
|
||
This is consistent with IsBaselineEnabled/IsIonEnabled and lets us handle the
JS_CODEGEN_NONE and no-floating-point-support cases the same way.
Depends on D36471
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6a0498d1ac61
https://hg.mozilla.org/mozilla-central/rev/d598861b5d41
https://hg.mozilla.org/mozilla-central/rev/8f67dc480b58
https://hg.mozilla.org/mozilla-central/rev/8cbfd166cb61
https://hg.mozilla.org/mozilla-central/rev/44bdb6882218
Description
•