Closed
Bug 1563331
Opened 5 years ago
Closed 5 years ago
Reftest regression from tab conversion
Categories
(Toolkit :: XUL Widgets, defect, P2)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | fixed |
People
(Reporter: bdahl, Assigned: aswan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
file_uri_broken.png
Over in bug 1557371 I'm converting all XUL reftests to be loaded with system privilege. In the process of doing that, it will fix a number of broken reftests. One of those broken tests that will be fixed is 272646-1.xul. However, in the last few days, bug 1555060 regressed the fixed test.
Str:
- apply patch
- run
./mach reftest layout/reftests/bugs/reftest.list
|
Reporter | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Comment 2•5 years ago
|
||
|
|
Reporter | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Component: XBL → XUL Widgets
Product: Core → Toolkit
|
||
Updated•5 years ago
|
Keywords: regression
|
|
Reporter | |
Comment 4•5 years ago
|
||
Comment on attachment 9075756 [details] [diff] [review]
chrome.patch
Now that the changes to reftests have landed the patch is no longer needed. Just run the reftest chrome://reftest/content/bugs/272646-1.xul
Attachment #9075756 -
Attachment is obsolete: true
|
|
||
Comment 5•5 years ago
|
||
The priority flag is not set for this bug.
:aswan, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(aswan)
|
Assignee | |
Comment 6•5 years ago
|
||
After bug 1555060, <tabs> elements should not use dom accessors to get
to the <tab> elements inside a <tabs>. This test was using lastChild,
this patch brings it up to date.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → aswan
Flags: needinfo?(aswan)
Priority: -- → P2
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/521e6dab1fd4
Fix obsolete use of <tabs> r=bdahl
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → affected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Whiteboard: [checkin-needed-beta]
|
|
||
Updated•5 years ago
|
Whiteboard: [checkin-needed-beta]
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•