Process pending transactions to https/1 end points when a tunnel through an h2 proxy becomes idle
Categories
(Core :: Networking: HTTP, defect, P1)
Tracking
()
People
(Reporter: mayhemer, Assigned: mayhemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged][secure-proxy-mvp])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release+
jcristau
:
approval-mozilla-esr68+
|
Details |
Extracted from https://bugzilla.mozilla.org/show_bug.cgi?id=1562887#c1. This is pretty much visible as a huge delay when connecting h1 secure servers and the connection can idle for a long time with the time out driven by the server (10, 15, 60 seconds...)
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Comment on attachment 9076292 [details]
Bug 1563538 - Propagate close reason through TLSFilterTransaction to allow tunnel stream reuse when possible + close the undelying tunnel stream when a tunneling connection is closed, r=dragana+kershaw
Beta/Release Uplift Approval Request
- User impact if declined: Very visible hangs or failed page loads when using h2 proxy.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The fix is isolated to h2 tunneling, is well understood and tested manually, and has a kill preference we may flip in case of trouble.
- String changes made/needed:
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Comment 6•5 years ago
|
||
Please add set-up steps for manual testing to repro this behavior with expected results.
|
|
Assignee | |
Comment 7•5 years ago
|
||
(In reply to Rebecca Billings [:rbillings] from comment #6)
Please add set-up steps for manual testing to repro this behavior with expected results.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1563695#c12
|
|
||
Comment 8•5 years ago
|
||
I tested multiple tabs and browsed through all of the sites above, running videos. I was not getting any consistent lags or delays in video playback or page load. Marking as Verified.
|
||
Updated•5 years ago
|
|
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9076292 [details]
Bug 1563538 - Propagate close reason through TLSFilterTransaction to allow tunnel stream reuse when possible + close the undelying tunnel stream when a tunneling connection is closed, r=dragana+kershaw
fix for http2 proxies, needed by secure-proxy project. approved for 68.0.1 and 68.1esr
|
|
||
Comment 10•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 11•5 years ago
|
||
Per discussion with jcristau, we're uplifting this to 68.0.1esr also to maintain parity with the non-ESR 68.0.1 release and hopefully avoid some confusion.
|
|
||
Comment 12•5 years ago
|
||
| uplift | ||
default (68.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/0256ae3b68fe31dcc2e21427e8a593e24f840e87
FIREFOX_ESR_68_0_X_RELBRANCH (68.0.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/c07873aa891e938b2c1e726d49dcb0f38a110486
Description
•