Bugbug thinks this bug is a task, but please change it back in case of error.

Hello @Honza
I would like to work on this !!
It would be great if you can explain this a bit more :)
thanks

Thanks for the offer of help.

The idea is to make all Set* methods of nsHttpConnectionInfo private-friend to a newly written "mutor" helper class. The mutator will have a mirror of all the Set* methods, public. It will create a clone of the given nsHttpConnectionInfo, modify this clone, and spit it out with a method alreaday_AddRefed<nsHttpConnectionInfo> Finalize(). Since then any Set* method call on the mutator will fail, best by throwing the reference to the nsHttpConnectionInfo object away. The Clone method of nsHttpConnectionInfo should also be made private or simply removed, when found fit.

Then, on all places where nsHttpConnectionInfo is modified by one of its Set* methods in our current code base (will simply pop-up during the build as an error when made private), replace it to use the mutator.

hey @Honza Bambas
You said I need to create class mutor(or mutator ?) . so it should be inside nsHttpConnectionInfo or outside it ?
How should I create it ? Can you explain a bit ?
and I need to create all set* functions like this inside mutor class ?
friend void nsHttpConnectionInfo::SetAnonymous(bool anon);
And what do you mean by clone of the given nsHttpConnectionInfo?

It's mostly about turning this:

class nsHttpConnectionInfo {
public:
  void SetFoo(Foo foo);
  Foo GetFoo();
private:
  Foo mFoo;
};

into something like this (not with necessarily the methods being inline):

class nsHttpConnectionInfo {
public:
  Foo GetFoo();

  Mutator {
  public:
    Mutator(nsHttpConnectionInfo* ci) {
      mCI = ci->Clone();
    }

    void SetFoo(Foo foo) {
      mCI->mFoo = foo; // this will work becaues nested classes see private members
    }
    
    already_AddRefed<nsHttpConnectionInfo> Finalize() {
      return mCI.forget();
    }

  private:
    RefPtr<nsHttpConnectionInfo> mCI;
  };

private:
  Foo mFoo;
};

the use of the Mutator is I believe obvious?

@Honza
Got it and will submit the patch as soon as possible :)
Thanks for help !!

hey @honza
Can you help me with this error

 /home/mahak/mozilla-central/netwerk/protocol/http/TRRServiceChannel.cpp:391:22: error: no member named 'SetNoSpdy' in 'mozilla::net::nsHttpConnectionInfo'
 0:05.73     mConnectionInfo->SetNoSpdy(true);

how do I change this using mutator class ?

@Honza
Should I submit the patch so that you can guide me in a better way ?

(In reply to Mahak from comment #8)

@Honza
Should I submit the patch so that you can guide me in a better way ?

Yes, I think it'd be good to submit your WIP patch.

Not sure whom to add as the reviewer ?

Hi Mahak,

I'd like to work on this one.
Please let me know if you'd like to continue with this.

Thank you.

Hi Kershaw!
Go ahead. I'm not working on this anymore
Thanks :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9a7c3b6c1f76db11501b7764f47b8f9044704f8

Depends on D91904

Depends on D91905

I think this is a WONTFIX, since copying a connection info every time introduce some extra performance overhead.