From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; es-HN; rv:1.0.0) Gecko/20020611 BuildID: 2002061103 When scrolling with the keyboard I can't use the keys PgUp or PgDn in the Sun 4 keyboard to scroll up and down. The keys "Page Up" and "Page Down" that exist in the couple of rows between the alphabetic and the numeric keyboard work as expected and allow scrolling. CDE applications recognize both couples of keys and allow scrolling with both indistinctly. Reproducible: Always Steps to Reproduce: 1.Go to any page that requires scrolling, press the keys PgUp and PgDn (Num Lock should be off). Actual Results: Nothing happens. Expected Results: I expect to scroll up or down a web page, one page at the time. The desired effect would be the one obtained using the "Page Up" and "Page Down" keys (located in the right end of the teo rows of keys to the left of the numeric keyboard and above the inverted T containing the arrows keys). Sun 4 keyboard. Solaris 2.8

.

Another Sun keyboard issue ...

Several seperated Sun-specific keys' problem have been fixed before, it seems that it was not the best solution to make every key work seperately, the better solution should be make a little biger patch to make all Sun-specific keys work at the same time. then all the related bugs can be fixed at one time.

taking.

Map Sun specail keysyms.

seek r=?

I doubt this is correct: -- snip -- +#if defined(SUNOS4) || defined(SOLARIS) +// map Sun Keyboard special keysyms on to NS_VK keys -- snip -- What happens if a user runs Netscape under Linux but the ${DISPLAY} is a Solaris Xsun Xserver ?

The keys will not work in that cases. But it is needed to define new NS_VK_F3x and DOM_VK_F3x and make mapping in XP code to let such situation work. I doubt if it is worth. Afterall, the PageUp PageDown outside the KeyPad already work.

IMHO it would be better to implement a portable solution which works on all platform&&Xserver combinations, otherwise we'll end-up in another bug report for that issue sooner or later.

Then we need a way to identify the Xserver in runtime, do you have clues on that?

Roland, have a look on the new patch?

The patch looks fine - but I see two nits: > if (!strcmp(XServerVendor(GDK_DISPLAY()), "Sun Microsystems, Inc.")) { 1. can you turn that into a macro (e.g. |IS_XSUN_XSERVER()| (or any name you want here :)) which takes the display to probe as argument, please ? 2. |strcmp()| may not be perfect here. If I recall correctly (Alan Coopersmith from Sun may correct me if I am wrong :) the vendor string differed between some Solaris releases; |strstr()| may be better in this case The final macro may look like this: #define IS_XSUN_XSERVER(dpy) (strstr(XServerVendor(dpy), "Sun Microsystems") != nsnull)

Looks better now. Thanks for Roland.

Comment on attachment 105309 [details] [diff] [review] patch_v3 (add Roland's comment) r=Roland.Mainz@informatik.med.uni-giessen.de minor nit: -- snip -- +// map Sun Keyboard special keysyms on to NS_VK keys +#define IS_XSUN_XSERVER(dpy) \ + (strstr(XServerVendor(dpy), "Sun Microsystems") != NULL) -- snip -- the macro should be above that comment, seperated at least with one newline from the array (no need to file an extra patch (unless the superreviewer wants a new one :), just fix that when you are doing the check-in).

Comment on attachment 105309 [details] [diff] [review] patch_v3 (add Roland's comment) >+ // map Sun Keyboard specail keysyms fix the misspelling. sr=bryner with that fix.

checked in Trunk.

jlms, does this work for you now? i don't have a sun box, so ->verifyme/qawanted

mass remove verifyme requests greater than 4 months old