Green up and re-enable wpt service-worker tests skipped on geckoview
Categories
(Core :: DOM: Service Workers, task, P3)
Tracking
()
People
(Reporter: impossibus, Assigned: jmarshall)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(2 files, 1 obsolete file)
web-platform-tests have been running against GeckoView for a couple of months, and we've found that the following tests have been unstable. I'm bulk disabling the most unstable tests based on this try push and filing this bug to track the work needed to turn them back on.
testing/web-platform/meta/service-workers/service-worker/claim-shared-worker-fetch.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1554991 (actually frequent)
testing/web-platform/meta/service-workers/service-worker/clients-matchall-client-types.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1352247
testing/web-platform/meta/service-workers/service-worker/clients-matchall-order.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1344484, https://bugzilla.mozilla.org/show_bug.cgi?id=1518237, https://bugzilla.mozilla.org/show_bug.cgi?id=1562728
testing/web-platform/meta/service-workers/service-worker/navigation-timing.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1560324, https://bugzilla.mozilla.org/show_bug.cgi?id=1481427, https://bugzilla.mozilla.org/show_bug.cgi?id=1481553
testing/web-platform/meta/service-workers/service-worker/unregister-then-register.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1523205
testing/web-platform/meta/service-workers/service-worker/unregister.https.html.ini | https://bugzilla.mozilla.org/show_bug.cgi?id=1299032
Pushed by mjzffr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/779a0418ce99 Disable service-workers web-platform-tests that are unstable on geckoview; a=testonly
Reporter | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
bugherder |
Reporter | ||
Comment 3•5 years ago
|
||
Here is the state of disabled tests according to testing/web-platform/meta at revision ad05396bfeed
service-workers/service-worker/claim-shared-worker-fetch.https.html.ini
[' Frequently failing on geckoview (Bug 1554991)']
service-workers/service-worker/client-navigate.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' bug 1550895 (frequently fails on geckoview)']
service-workers/service-worker/clients-matchall-client-types.https.html.ini
[' Frequently failing on geckoview (Bug 1550895, Bug 1352247)']
service-workers/service-worker/clients-matchall-include-uncontrolled.https.html.ini
[' bug 1550895 (frequently fails on geckoview)']
service-workers/service-worker/clients-matchall-order.https.html.ini
[' Frequently failing on geckoview (Bug 1518237)', ' Frequently failing on geckoview (Bug 1344484)', ' Frequently failing on geckoview (Bug 1562728)']
service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972']
service-workers/service-worker/import-scripts-redirect.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972']
service-workers/service-worker/installing.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972']
service-workers/service-worker/navigation-timing.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1560324', ' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' Frequently failing on geckoview (Bug 1481427)', ' Frequently failing on geckoview (Bug 1560324, Bug 1481553)']
service-workers/service-worker/postmessage-to-client-message-queue.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972']
service-workers/service-worker/postmessage.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' https://bugzilla.mozilla.org/show_bug.cgi?id=1490546']
service-workers/service-worker/unregister-then-register.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' Frequently failing on geckoview (Bug 1523205)']
service-workers/service-worker/unregister.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' Frequently failing on geckoview (Bug 1299032)']
service-workers/service-worker/update-not-allowed.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' bug 1550895 (frequently fails on geckoview)']
service-workers/service-worker/update-registration-with-type.https.html.ini
[' https://bugzilla.mozilla.org/show_bug.cgi?id=1499972', ' bug 1550895 (frequently fails on geckoview)']
Reporter | ||
Comment 4•5 years ago
|
||
Andrew, I know there's a refactoring coming up in service-workers that will change these results. Nevertheless, could you assign someone to turn these disabled tests back on and green them up? Thanks!
Reporter | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Hsin-Yi is actually the manager of the team so I'll defer to her.
Comment 6•5 years ago
|
||
Thanks for bringing this up. I'll take an action and see how we can have a plan.
Comment 8•5 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
Comment 10•5 years ago
|
||
I suspect that some tests could be reenabled but not all, in which case this would need to remain open. I'll run some tests to see what might be able to be reenabled...
Comment 11•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/176b25eb03db re-enable some SW WPTs on GeckoView r=dom-workers-and-storage-reviewers,ytausky
Comment 13•5 years ago
|
||
Remaining GeckoView SW WPTs to be re-enabled, according to comment 3 and patch D59944:
service-workers/service-worker/client-navigate.https.html.ini
service-workers/service-worker/clients-matchall-include-uncontrolled.https.html.ini
service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html.ini
service-workers/service-worker/import-scripts-redirect.https.html.ini
service-workers/service-worker/installing.https.html.ini
service-workers/service-worker/postmessage-to-client-message-queue.https.html.ini
service-workers/service-worker/postmessage.https.html.ini
service-workers/service-worker/update-not-allowed.https.html.ini
service-workers/service-worker/update-registration-with-type.https.html.ini
Comment 14•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 15•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
Comment 17•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
Updated•4 years ago
|
Comment 18•3 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
Updated•3 years ago
|
Comment 19•3 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
Comment 20•3 years ago
|
||
(In reply to Perry Jiang [:perry] [no longer employee, use ni?] from comment #13)
Remaining GeckoView SW WPTs to be re-enabled, according to comment 3 and patch D59944:
service-workers/service-worker/client-navigate.https.html.ini
service-workers/service-worker/fetch-event-respond-with-readable-stream.https.html.ini
service-workers/service-worker/import-scripts-redirect.https.html.ini
service-workers/service-worker/postmessage-to-client-message-queue.https.html.ini
service-workers/service-worker/postmessage.https.html.ini
Some progress on the above, but the following tests are still (partially) disabled:
service-workers/service-worker/clients-matchall-include-uncontrolled.https.html.ini
service-workers/service-worker/installing.https.html.ini
service-workers/service-worker/update-not-allowed.https.html.ini
service-workers/service-worker/update-registration-with-type.https.html.ini
Comment 23•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:edenchuang, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Updated•1 year ago
|
Comment 24•1 year ago
|
||
Joshua, could you please verify which tests are still disabled and try to understand if there are low hanging fruits?
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 25•1 year ago
|
||
Assignee | ||
Comment 26•1 year ago
|
||
Updated•1 year ago
|
Comment 27•1 year ago
|
||
Pushed by jmarshall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d70485ffa51e Re-enable a few geckoview tests r=dom-worker-reviewers,smaug
Comment 28•1 year ago
|
||
bugherder |
Description
•