Use MaybeUninit instead of mem::uninitialized in WebRender
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: SimonSapin, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Part of bug 1563623.
Reporter | ||
Comment 1•5 years ago
|
||
MozReview-Commit-ID: 67kmn5v43eW
Reporter | ||
Comment 2•5 years ago
|
||
MozReview-Commit-ID: 9ZW2dQiO60z
Reporter | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
There are no reviewers specified on these patches. Is that intentional?
Reporter | ||
Comment 5•5 years ago
|
||
Added gfx
as a reviewer. I think it represents anyone in that group?
Comment 6•5 years ago
|
||
(In reply to Simon Sapin (:SimonSapin) from comment #5)
Added
gfx
as a reviewer. I think it represents anyone in that group?
I chnaged the reviewer to Gankro. The gfx
reviewer is left over from the early WR workflows but isn't really used now. I'll remove that phabricator account if I can.
Comment 7•5 years ago
|
||
Alexis, do you mind taking a look at this again? 1.39 turns this into a warning which broke our CI. As a workaround we'll probably switch to 1.38 but we should probably do something sooner rather than later.
Comment 8•5 years ago
|
||
Do you want me to do it or is Simon planning a rebase?
Comment 9•5 years ago
|
||
I have no preference. I'll let you two fight it out.
Reporter | ||
Comment 10•5 years ago
|
||
Alexis, could you take over? I started this hoping apply similar patterns of changes in all of Gecko, but that Vec of GPU data probably deserves more attention than that and I don’t really understand what makes it sound or how it could be made sound.
Reporter | ||
Comment 11•5 years ago
|
||
This should also revert https://phabricator.services.mozilla.com/D52360
Updated•5 years ago
|
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
Use Vec::reserve + as_ptr, then raw pointers.
Alternative is to require T: Default, and then push T::default() or something.
Depends on D53359
Comment 14•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 15•5 years ago
|
||
bugherder |
Comment 16•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 17•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•