Add AMD Navi GPU's to WebRender qualified device list
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
People
(Reporter: snecknico, Assigned: jrmuizel)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
According to a Reddit comment AMD Navi10 GPU's aren't on the WebRender qualified devices whitelist (confirmed by checking the qualified device list https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxPlatform.cpp#l2638 ).
Unsure of what the protocol is in adding new GPU's to said qualification list, does someone need to test and confirm the devices work with WebRender? Also unsure where to find the device ID's for said devices, otherwise I would've submitted a patch to add them.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
We keep track of the device IDs here: https://github.com/jrmuizel/gpu-db. I've updated that to include NAVI10 and made a patch to add them to the white list.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
Sounds like we definitely want to uplift this to Beta. I'm less sure about Release, though.
Assignee | ||
Comment 6•5 years ago
|
||
We can uplift to beta. I don't think I'd want to uplift to release.
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9077105 [details]
Bug 1564907. Add AMD Navi GPUs to WebRender qualified device list.
Beta/Release Uplift Approval Request
- User impact if declined: AMD users with new GPUs don't get WebRender
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Comment on attachment 9077105 [details]
Bug 1564907. Add AMD Navi GPUs to WebRender qualified device list.
Enables WebRender for newer AMD GPUs by default. Approved for 69.0b5.
Comment 9•5 years ago
|
||
Conflict while trying to uplift this patch on Beta on file: gfx/thebes/gfxPlatform.cpp
Comment 10•5 years ago
|
||
uplift |
Conflict was due to indentation change.
https://hg.mozilla.org/releases/mozilla-beta/rev/1d8031f29e6767da7bc39d5fabc6f209cb3b3e83
Description
•