Closed Bug 1565090 Opened 5 years ago Closed 5 years ago

about:certificate has bad tab styling in dark mode

Categories

(Firefox :: Theme, defect, P3)

69 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: yoasif, Assigned: danielleleb12)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

STR:

  1. Ensure in content dark pages are enabled.
  2. Navigate to about:certificate

What happens:

The tab0 and tab1 tabs (is this another bug?) look out of place in dark mode. This persists when a user hovers over the tabs.

Priority: -- → P3
Blocks: cert-viewer

Danielle, can you take a look at this? :)

The tab0 and tab1 tabs (is this another bug?)

Nope, this is just not ready for public consumption yet.

Flags: needinfo?(danielleleb12)

Yeah the tab names are just placeholders for the time being :) as for the colors, I'll do up a patch now. Thanks for pointing this out!

Flags: needinfo?(danielleleb12)

Depends on D37745

Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ea63057dda0
Improves styling of certificate tabs in dark theme. r=johannh

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → danielleleb12
QA Whiteboard: [qa-70b-p2]

Tested on the latest Fx71.0a1 in windows 10, Ubuntu 18 and macOS 10.13. On windows 10, it's been tested with windows dark mode as well, beside the firefox dark theme and there were no issues found.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: