Closed
Bug 1565171
Opened 5 years ago
Closed 5 years ago
Add routing support - Part 2: Implement a page switcher component
Categories
(DevTools :: Application Panel, enhancement, P1)
DevTools
Application Panel
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: ogasidlo, Assigned: ladybenko)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Scope:
- move SW component to
components/service-worker
folder - fix paths in build files + tests
- add routes for service worker
/service-worker
- add test for
/service-worker
route - make sure all tests pass
Assignee | ||
Comment 1•5 years ago
|
||
NEW scope, since we did the routing bug re-organisation:
- Add Redux state to keep track of that's the current page
- Add a page switcher component that renders one component or the other depending on Redux state
- Add Redux action(s) to switch to a new page
Summary: Add `/service-worker` route → Add routing support - Part 2: Implement a page switcher component
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee | ||
Comment 2•5 years ago
|
||
This patch implements a page switcher component (PageContainer
) and a new Redux substate (UiState
) to handle which page is shown. At the moment, only service workers page is supported. The aim of this patch is to enable support to add new pages later on and be able to switch between them easily.
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/146d6da6f53c
Add routing support part 2: Implement a page switcher component r=nchevobbe
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•