TEST-UNEXPECTED-FAIL | comm/mail/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | uncaught exception - ReferenceError: gListView is not defined at @chrome://messenger/content/aboutAddonsExtra.js:75:3
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
People
(Reporter: jorgk-bmo, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Mochitests (bct) are broken as of 2019-07-11, also linting errors saying about the same:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mail/base/content/aboutAddonsExtra.js:75:3 | 'gListView' is not defined. (no-undef)
Reporter | ||
Comment 1•5 years ago
|
||
Looks like this is from:
Andrew Swan - Bug 1563062 Part 2: Remove unused bits of old about:addons r=mstriemer
https://hg.mozilla.org/mozilla-central/rev/4fb3655540652629dffdbe4c93f43f3d982f5fe2#l3.1445
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
That X3 is probably about to appear on comm-central too. I can't see it being related to this bug.
Reporter | ||
Comment 5•5 years ago
|
||
Hmm, but it wasn't on the latest trunk run, so where did it come from?
Reporter | ||
Comment 6•5 years ago
|
||
Hmm again. The test fails intermittently as treeherder suggests. It doesn't fail locally with or without the patch here.
Reporter | ||
Comment 7•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
We could also set the pref extensions.htmlaboutaddons.recommendations.enabled
to false. Then the empty "Recommended Extensions/Themes" below the extensions would be no more shown.
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #7)
no idea what's going on with losing the quotes, etc.
You mean this? That's because mozilla-central has run Prettier since we copied the file from there.
- "policies": {
- "Extensions": {
- "Uninstall": [
- addonID,
- ],
- "Install": [
- `${BASE_URL}/policytest_v0.2.xpi`,
- ],
+ policies: {
+ Extensions: {
+ Uninstall: [ADDON_ID],
+ Install: [`${BASE_URL}/policytest_v0.2.xpi`],
Assignee | ||
Comment 12•5 years ago
|
||
Though this is a temporary fix, we already have bug 1565180 to reinstate it, so I'm closing this.
Assignee | ||
Updated•5 years ago
|
Description
•