Closed Bug 1565179 Opened 5 years ago Closed 5 years ago

Addon popups are blank on sway

Categories

(Core :: Widget: Gtk, defect, P3)

68 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: lynx1534, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Attached image screensot.png (obsolete) (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

  1. Start Firefox in sway wayland compositor (ensure it's running natively on wayland)
  2. Install uMatrix or Browserpass addons
  3. Click on addon button to open the popup

Actual results:

Popup is displaced to the right, but just visually, actual interactive elements of the popup are located where they should be, which causes major inconvenience because the interactive elements are displaced from their visualisation on the screen. Also this is not 100% reproducible: sometimes it does not happen and everything works normally and sometimes it is misplaced by much larger value (drawn partially out of screen). Also this issue happens not for all addons. In my case I have uMatrix, uBlock, Browserpass and Web Scrobbler addon icons on the panel, but I have this problem only with uMatrix and Browserpass. I tried to rearrange icons on the panel, but the order does not matter, the problem is always with the same addons.

Expected results:

Popup displayed exactly under the addon button.

Component: Untriaged → Layout
Product: Firefox → Core

Hi
Can you test using Firefox Nightly release from here: https://nightly.mozilla.org/

If you still have the issue please create a new profile, you have the steps here:https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Regards
Pablo

Tested using nightly. Bug persists. Nightly starts on the separate profile by default, so the second step is unneeded.

Blocks: wayland
Component: Layout → Widget: Gtk

Here's the bug I filed for nightly, where it's also broken: https://bugzilla.mozilla.org/show_bug.cgi?id=1567636

Blocks: wayland-sway
No longer blocks: wayland
Priority: -- → P3

I was not able to reproduce this, but in my case i tested it on ubuntu 18.04.02 LTS 64bit with Firefox Release 68.0.1
(Sway not available on this machine)

In firefox-69 this no longer happens. But popups of the same extensions are just empty instead. Just blank pages with the background colour of the original popup. Also it doesn't happen if I pin these extensions to the overflow menu.

For anyone looking for quick workaround, instead of simply clicking icons you can click and hold them for at least a second and they will always show up.

Also affected by this bug, sway archlinux.

(In reply to roshless from comment #6)

I confirm, this workaround does work.

Attached image out.png (deleted) —

Now that's how it looks like.

Attachment #9077349 - Attachment is obsolete: true
Summary: Addon popups are displaced on sway → Addon popups are blank on sway

@EternalSorrow It may be better to open a new bug for blank popups. This bug is about the displacement as per the original post, and the displacement itself is not yet solved.

@roshless Could you elaborate on why clicking for one second works ? How did you get the information ? Do you have code/upstream references ?

Flags: needinfo?(firefox-bugs)

(In reply to Guillaume Maudoux [:layus] from comment #10)

@roshless Could you elaborate on why clicking for one second works ? How did you get the information ? Do you have code/upstream references ?

No, I have nothing. Just happened to press mouse button too long.

This also sometimes happens with noscript, but every time in browserpass. My only guess is that it doesn't handle refreshes/resizes of new window very well. When you click browserpass icon it looks for pass entries with names that match current website. I can see text there "loading available logins" and sometimes can see yellow bar with current domain but it will never show entries, it might be resizing the window to fit entries but that's only my speculation.

videos showing this:
normal - https://i.imgur.com/yEJ8vpP.mp4
long - https://i.imgur.com/5vdGm1a.mp4

Flags: needinfo?(firefox-bugs)

I've hit this since 65 at least iirc, the long click workaround is nice to know though (helps me too)

I should also note that I've gotten crashes doing this too (quick clicks over and over to try to get the addon contents to display). Can take a while though.

Hi Matthew,

I have exactly the same behavior than you.
But something strange, I have two laptop with almost the same configuration (Archlinux, sway, Firefox current version 70) but only one setup have this bug.
So I suspect if this is not trigger by a specific firefox configuration…

FF70, bug still here.

Motivated by mozneth's comment I also tried firefox on second computer (thinkpad X230), also Arch Linux with sway.
Both uMatrix and browserpass work properly without need to press longer. I can see the moment when they refresh content of window but it still renders after that just fine.
Seems like this might be related to gpu drivers. X230 has integrated intel hd, my desktop has radeon rx 580 (amdgpu).

The computer I encounter it on is a lenovo x1 carbon 5th gen. So it matches the thought of intel causing the failure. I do wonder if it could be related to the speed though. since your rx 580 is so much faster it could just mean that you need less time to render and less time to 'hold the button down' on click, so a false negative.

My two laptops have an intel GPU…

(In reply to Matthew Thode from comment #17)

The computer I encounter it on is a lenovo x1 carbon 5th gen. So it matches the thought of intel causing the failure. I do wonder if it could be related to the speed though. since your rx 580 is so much faster it could just mean that you need less time to render and less time to 'hold the button down' on click, so a false negative.

It's the other way around, it works fine on slower x230, on rx 580 popups are blank most of the time.
Also I don't use firefox on this laptop and didn't change many settings, so the profile is definitely more "clean".

(In reply to mozneth from comment #18)

My two laptops have an intel GPU…

Seems like drivers aren't the cause then.

I have a log now (I don't remember seeing this in firefox version <70), when I am short-clicking on the addon which trig an empty popup I have the following log :

[GFX1-]: We don't have EGLSurface to draw into. Called too early?

If i long-click on the addon, I don't have this message nor the empty popup.

I don't see this problem in FF 71.0~b7+build1-0ubuntu0.19.10.1 (webrender and basic) and sway 1.2 / wlroots 0.8.1

same here sway 1.2 / wlroots 0.8.1 happens in firefox 71beta12 as well.

Attached image 2019-11-26-154006-ss.png (deleted) —

I didn't notice when (because I still was using long press workaround) but it seems short, normal click works for me now.
Add-on window resizes properly.
Firefox 71 sway 1.2 wlroots 0.8.1

(In reply to roshless from comment #24)
Still blank popups here.

the same Firefox 71 sway 1.2 wlroots 0.8.1

On FF 72 I don't see this bug anymore.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Are the blank popups issue fixed for everyone? I'm FF 83 Dev Edition, latest Sway 1.5 / Wayfire 0.5 / wlroots 0.11 - and I see it all the time. Long clicking doesn't seem to help.

My mistake - I had WebRender enabled forcefully from the about:config. After disabling it the popups are appearing normally. Sorry for the double posting, can't find a way to edit.

(In reply to bjesus from comment #27)

Are the blank popups issue fixed for everyone? I'm FF 83 Dev Edition

That's bug 1672139. :-/

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: