Centralize property restrictions for pseudo-elements, and don't apply it for UA sheets.
Categories
(Core :: CSS Parsing and Computation, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(5 files)
Bug 1565214 - Don't apply property restrictions to pseudo-elements in UA stylesheets. r=boris,#style
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
Having the flags on each property makes it hard to audit for spec conformance.
Also, making them apply in UA sheets means we have to mark some properties as applying even though they don't, and then we have to remember them in UA sheets.
I was hacking with the placeholder styles for bug 981248, and this patch makes it much nicer / less brittle.
Assignee | ||
Comment 1•5 years ago
|
||
And remove some of the ::placeholder and ::cue hacks where we need to use
!important to make the property not apply for content but apply on UA sheets.
The comment about the white-space property was wrong, we don't enforce it with
!important in the UA stylesheets for <input> (we do for <textarea> though), so
I've kept the flag since it really applies.
Assignee | ||
Comment 2•5 years ago
|
||
It had got outdated.
Depends on D37717
Assignee | ||
Comment 3•5 years ago
|
||
From https://drafts.csswg.org/css-scroll-snap-1/#placement:
None of the properties in this module apply to the ::first-line and
::first-letter pseudo-elements.
Depends on D37718
Assignee | ||
Comment 4•5 years ago
|
||
The assertion in properties.mako.rs ensures I got this right.
Depends on D37719
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D37720
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/35d45a1cd0b4
https://hg.mozilla.org/mozilla-central/rev/0abaee26ddf8
https://hg.mozilla.org/mozilla-central/rev/a72cf3fdb84b
https://hg.mozilla.org/mozilla-central/rev/9893d5f0a7ba
https://hg.mozilla.org/mozilla-central/rev/29438d93b50a
Description
•