Closed
Bug 1565556
Opened 5 years ago
Closed 5 years ago
More cleanups in SharedScriptData
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
There are small inconsistencies and comments to fix as follow-up to SharedScriptData changes.
As well, this will be renamed to ImmutableScriptData since RuntimeScriptData/SharedScriptData is a bit confusing.
|
Assignee | |
Comment 1•5 years ago
|
||
Add an 'Offset' type-alias to better document as well as fixing up
out-of-date comments. This also moves the optArrayOffset to beginning of
structure.
|
|
Assignee | |
Comment 2•5 years ago
|
||
After this patch a JSScript will have Private, Runtime, and Immutable
script data type attached to it.
Depends on D37866
|
|
Assignee | |
Comment 3•5 years ago
|
||
With the current design of ImmutableScriptData, even empty arrays have a
legal span so we no longer need to change the hasTryNotes and friends
helpers. In most cases we were performing a range-for afterwards so this
has simpler semantics.
|
|
Assignee | |
Updated•5 years ago
|
Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6e96caa9f2d
Cleanup SharedScriptData optional arrays. r=jandem
https://hg.mozilla.org/integration/autoland/rev/9056a9e2cf4a
Rename SharedScriptData to ImmutableScriptData. r=jandem
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/552b13ce8016
Remove JSScript::hasTryNotes/ScopeNotes/ResumeOffsets. r=jandem
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•