Closed
Bug 1565687
Opened 5 years ago
Closed 5 years ago
Toggle password button doesn't work in about:logins
Categories
(Firefox :: about:logins, defect, P1)
Firefox
about:logins
Tracking
()
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | disabled |
| firefox70 | --- | fixed |
People
(Reporter: ntim, Assigned: jaws)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [passwords:management] [skyline])
Attachments
(2 files, 1 obsolete file)
image.png
No description provided.
|
||
Updated•5 years ago
|
Whiteboard: [passwords:management] [skyline]
|
Assignee | |
Comment 1•5 years ago
|
||
Can you find when this regressed? I thought we had an automated test for this. The screenshot doesn't show any bug by the way. The eye is supposed to be opened when the characters are hidden.
Flags: needinfo?(ntim.bugs)
|
Reporter | |
Comment 2•5 years ago
|
||
Attachment #9077822 -
Attachment is obsolete: true
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 3•5 years ago
|
||
This is the smallest regression range I could find: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac50a7bd09b0a9262eed73f9dee2ffbd0e1a33b2&tochange=b7030ce607ec56690829e8fb6dbcd27dd54a044c
So it sounds like bug 1558242 ?
Keywords: regression
Regressed by: 1558242
|
|
Assignee | |
Comment 4•5 years ago
|
||
Thanks, it was https://hg.mozilla.org/mozilla-central/rev/b979c5a32ffd19ab2502bcb07fb3e7c57863bb44
The event listener for .reveal-password-checkbox was not kept when changing how the event listeners were added.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: qe-verify-
Flags: in-testsuite?
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•5 years ago
|
Flags: in-testsuite? → in-testsuite+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30b8d57cb72a
Add back the lost event listener for the reveal-password-checkbox and add some more tests for it. r=MattN
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → disabled
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
||
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•