Closed
Bug 1565714
Opened 5 years ago
Closed 5 years ago
Disabled breakpoint numbers should be a shade of blue
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jlast, Assigned: shellyc23)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files, 1 obsolete file)
Screen Shot 2019-07-12 at 12.34.00 PM.png
We try and polish every detail of breakpoints down to the color of the breakpoint line number text color. One case we do not handle well is disabled breakpoints, which are the active line number grey. We should update it to be a blue that is darker than disabled breakpoints, which will be slightly more refined.
|
Reporter | |
Updated•5 years ago
|
Keywords: good-first-bug
Priority: -- → P3
|
|
Reporter | |
Comment 1•5 years ago
|
||
|
Assignee | |
Comment 2•5 years ago
|
||
I would like to try my hand at this.
I noticed when disabling breakpoints, they appear white though.
|
|
Assignee | |
Comment 3•5 years ago
|
||
In Breakpoint.js I added an if else statement to the function addBreakpoint() to add/remove class "breakpoint-disabled" depending on the value of breakpoint.disabled. I then added a selector in Editor.css to set color: blue.
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56582e290c63
Disabled breakpoint numbers should be a shade of blue
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
Assignee: nobody → shellyc23
|
||
Updated•5 years ago
|
Attachment #9078027 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•