Closed Bug 1565812 Opened 5 years ago Closed 4 years ago

Duo 2FA broken with fission.autostart enabled

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Fission Milestone M5
Tracking Status
firefox70 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix

People

(Reporter: bc, Unassigned)

References

Details

  1. enable fission.autostart
  2. restart
  3. visit sso.mozilla.com
  4. login
  5. select email
  6. enter password
  7. get duo 2fa auth, select passcode
  8. tab to passcode input as mouse doesn't work
  9. enter passcode
  10. successful login message but do not complete authentication.
Fission Milestone: --- → M5
Priority: -- → P3

Should there be a separate bug on step (8) above -- that clicking with the mouse doesn't work (and it wasn't obvious to me that tabbing would)... or should this bug cover both 8 and 10?

Curious. This works for me, although on one attempt I did get some sort of TLS error to do with an END OF FILE error at step #10. On reloading sso.mozilla.com I discovered that I had been successfully logged in even that time though.

I'm using a yubikey to provide the code at step #9, but I guess that probably shouldn't make any difference?

jcj, I don't suppose you have any off-the-cuff insights?

Flags: needinfo?(jjones)

Afraid not - this seems like it should just be standard javascript text form handling stuff...

Flags: needinfo?(jjones)

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #1)

Should there be a separate bug on step (8) above -- that clicking with the mouse doesn't work (and it wasn't obvious to me that tabbing would)... or should this bug cover both 8 and 10?

The mouse bug is bug 1556627.

I can't reproduce this. Please reopen if it's still happening.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Original report still stands for all steps. I had to log out and then delete all my mozilla cookies to make sure to get the 2fa prompt.

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

Same here - I had to remove all Mozilla cookies and then I was able to log back in, on sso.mozilla.com, with fission enabled.

Which platforms are you seeing this on? Also, although it probably doesn't matter, which 2fa apps are you using? I'm seeing the prompt on OS X with both Google Authenticator and Duo Mobile.

Flags: needinfo?(mpurzynski)
Flags: needinfo?(bob)

Fedora Linux x86_64 and Google Authenticator for me. Are you able to successfully log in?

Flags: needinfo?(bob)

(In reply to Bob Clary [:bc:] from comment #10)

Fedora Linux x86_64 and Google Authenticator for me.

I can test on Fedora tomorrow.

Are you able to successfully log in?

Yes. I also don't need to use tab to select the input (click works).

Flags: needinfo?(kmadan)

(In reply to :kashav from comment #11)

I can test on Fedora tomorrow.

Login works for me on Fedora as well. Interestingly, I can't click the input here.

(In reply to Bob Clary [:bc:] from comment #0)

  1. successful login message but do not complete authentication.

What does it mean to not complete authentication? When you go back to sso.mozilla.com, does it ask you to login again? Are you using a non-regular tab (private/container)?

Flags: needinfo?(kmadan) → needinfo?(bob)

After entering the 2fa code, I receive the message "Success! Logging you in..." but the page does not refresh. If I visit sso.mozilla.com immediately afterwards, it takes me back to the login page. No containers no private tabs.

Flags: needinfo?(bob)
Flags: needinfo?(mpurzynski)

(In reply to Bob Clary [:bc:] from comment #13)

After entering the 2fa code, I receive the message "Success! Logging you in..." but the page does not refresh. If I visit sso.mozilla.com immediately afterwards, it takes me back to the login page. No containers no private tabs.

I have the same issue logging into https://mozilla.1password.com/signin when fission is enabled.

@ Bob, does Duo 2FA login with Fission work for you now? SetFocus bug 1556627 has been fixed.

Flags: needinfo?(bob)

(In reply to Gary Chen [:xeonchen] from comment #14)

I have the same issue logging into https://mozilla.1password.com/signin when fission is enabled.

@ Gary, does 1Password signin with Fission work for you now?

Flags: needinfo?(xeonchen)

No, it still does not work. comment 13 still stands with the exception that the input is focused already.

Flags: needinfo?(bob)

(In reply to Chris Peterson [:cpeterson] from comment #16)

(In reply to Gary Chen [:xeonchen] from comment #14)

I have the same issue logging into https://mozilla.1password.com/signin when fission is enabled.

@ Gary, does 1Password signin with Fission work for you now?

I just created a new profile to test, and YES, it works pretty well.
Thanks for the efforts.

Flags: needinfo?(xeonchen)

I just created a fresh profile and successfully logged in with fission with a single tab containing sso. I also cleared the data and attempted again with other tabs loaded and was also able to log in again. I repeated with strict tracking protection enabled (which I have enabled on my normal profile) and also successfully logged in. Perhaps it is just the old profile/data. I'll try there again in a moment.

I was unable to login with fission enabled and my normal profile. I also had some problems with focusing the input via the mouse again.

(In reply to Bob Clary [:bc:] from comment #20)

I was unable to login with fission enabled and my normal profile.

In that case, I will leave this bug in our current Fission milestone. Being able to log in is pretty important!

I also had some problems with focusing the input via the mouse again.

Did you have those mouse focus problems in both your normal and fresh profiles?

Normal.

It also still doesn't work for me. I no longer see the "mouse doesn't work" problem in comment 0 step 8, but I see step 10 that the redirects don't successfully complete. However, it seems like, despite that they didn't complete redirecting, I did end up logged in and trying to load the site again from the start did work. (I only tried once, since I've only needed to log in once since re-enabling the fission.autostart pref.)

(update for comment 18)
I can't login on my daily profile today when fission is enabled, either.

Bob, can you share your about:support info or a diff of the perfs.js files in your two profiles?

The Fission engineers wonder if you have any non-default pref values that might interfere with Fission (such as browser.tabs.documentchannel = false).

Flags: needinfo?(bob)

fwiw, browser.tabs.documentchannel is true. Ok if I attach about:support as a private attachment?

Flags: needinfo?(bob)

(In reply to Bob Clary [:bc:] from comment #26)

Ok if I attach about:support as a private attachment?

SGTM

about:support doesn't include any private user information, other than installed extensions so no need for concern. :)

Is this your Fission profile? I don't see fission.autostart in your about:support's modifiedPreferences list.

This is my normal profile which had problems when enabling fission. I turned fission off after the failure to login.

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 from comment #23)

It also still doesn't work for me. I no longer see the "mouse doesn't work" problem in comment 0 step 8, but I see step 10 that the redirects don't successfully complete. However, it seems like, despite that they didn't complete redirecting, I did end up logged in and trying to load the site again from the start did work. (I only tried once, since I've only needed to log in once since re-enabling the fission.autostart pref.)

Bob and David, can you still reproduce this bug with Fission in 77 Nightly?

I can select the passcode input field using the mouse (STR step 8). The field has input focus by default, but I can click the focus in and out of the field using the mouse. And the authentication redirects (STR step 10) complete successfully for me.

Flags: needinfo?(dbaron)
Flags: needinfo?(bob)

@cpeterson: I can't seem to get duo to prompt me. I logged out and deleted my duo cookie and all of my mozilla cookies. I'll leave fission enabled in case it prompts me again later.

Bob or David, have you seen this Duo input problem again?

I haven't tested for a while since it turns out my laptop doesn't really have enough RAM to dogfood fission given the current memory usage and the current size of my Firefox session...

I've been running with fission since 4/17 and though I have seen several 2fa duo prompts for other properties I was unable to get it to fire for sso. So far, everything has been working nicely but I'm concerned about keeping fission enabled. If you have some pointers on how to reliably force sso to prompt me for the 2fa please ping me on slack or riot that would be great. I'll try once again to log out of everything and see if I can't get the prompt.

I realized I could use my old laptop that has been sitting idle but the laptop fails with incorrect passcode most of the time with or without fission. I did finally get it to work both with and without fission. Apart from the random passcode failures fission works well and I didn't see the original issues with the mouse or redirection after logging in.

Resolve WFM or wait for more confirmation?

Flags: needinfo?(bob)

Thanks for testing. I'll resolve WFM for now.

Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Flags: needinfo?(dbaron)
Resolution: --- → WORKSFORME

fwiw, I hit the duo 2fa today accessing training. I logged out, enabled fission, l restarted and used duo for sso and for the security training sso and both worked fine with fission.

You need to log in before you can comment on or make changes to this bug.