bugs/256180-4.html crashes mingwclang x86 opt build
Categories
(Firefox Build System :: General: Unsupported Platforms, defect)
Tracking
(firefox-esr60 unaffected, firefox-esr6869+ fixed, firefox68- wontfix, firefox69 wontfix, firefox70 fixed)
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr68+
|
Details |
Runs/dumps here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=372a9bb41490f95a1292c34ccb86e89251457440&selectedJob=256363517
Strangely enough for me it does not crash when I load this file locally...
Bug 1530033 was the same thing for aarch64 and https://bugzilla.mozilla.org/show_bug.cgi?id=1530033#c4 says
The test relies on Firefox having a non-default runtime stack size on Windows. https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/config/config.mk#293 needs to be adjusted to set the stack size to 8 MB on aarch64 Windows, too.
They fixed the stack size in Bug 1536575
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
[Tracking Requested - why for this release]: This fixes a corner-case bug in firefox
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a corner-case bug in firefox: extensively-nested DOM elements caused a stack overflow in our html parser that wa sinconsistent with other engines. We needed to bump the stack size to avoid crashing on the same input.
- User impact if declined: Tor will need to backport the patch
- Fix Landed on Version: 70a1: 7/18/2019
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Only affects MinGW builds.
- String or UUID changes made by this patch:
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4367ea6b63f
Bump the stack size on mingwclang builds r=firefox-build-system-reviewers,mshal
Comment 5•5 years ago
|
||
bugherder |
Comment 6•5 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build
Bumps the stack size for MinGW builds. NPOTB for official Firefox builds. Approved for 68.1esr.
Comment 8•5 years ago
|
||
bugherder uplift |
Description
•