Closed Bug 1565877 Opened 5 years ago Closed 5 years ago

bugs/256180-4.html crashes mingwclang x86 opt build

Categories

(Firefox Build System :: General: Unsupported Platforms, defect)

defect
Not set
normal

Tracking

(firefox-esr60 unaffected, firefox-esr6869+ fixed, firefox68- wontfix, firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 69+ fixed
firefox68 - wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Runs/dumps here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=372a9bb41490f95a1292c34ccb86e89251457440&selectedJob=256363517

Strangely enough for me it does not crash when I load this file locally...

Bug 1530033 was the same thing for aarch64 and https://bugzilla.mozilla.org/show_bug.cgi?id=1530033#c4 says

The test relies on Firefox having a non-default runtime stack size on Windows. https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/config/config.mk#293 needs to be adjusted to set the stack size to 8 MB on aarch64 Windows, too.

They fixed the stack size in Bug 1536575

[Tracking Requested - why for this release]: This fixes a corner-case bug in firefox

Keywords: checkin-needed

Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a corner-case bug in firefox: extensively-nested DOM elements caused a stack overflow in our html parser that wa sinconsistent with other engines. We needed to bump the stack size to avoid crashing on the same input.
  • User impact if declined: Tor will need to backport the patch
  • Fix Landed on Version: 70a1: 7/18/2019
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects MinGW builds.
  • String or UUID changes made by this patch:
Attachment #9078036 - Flags: approval-mozilla-esr68?

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4367ea6b63f
Bump the stack size on mingwclang builds r=firefox-build-system-reviewers,mshal

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build

Bumps the stack size for MinGW builds. NPOTB for official Firefox builds. Approved for 68.1esr.

Attachment #9078036 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: