Closed Bug 1565904 Opened 5 years ago Closed 5 years ago

Move the blob metadata from image space to an absolute space.

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

This is a follow up to bug 1564655. It removes the offset from ToDeviceSpace
and thus moves item rects into absolute space which is now the same coordinate
space as the recordings are in.

We also adjust item bounds for fallback blobs.

Some additional changes that need happen to:

  1. In Moz2DImageRenderer we can reunify the origin because the recording and
    the recording metadata return to using the same coordinate space.

  2. The calls to PushLayer can return to using the item bounds
    which are now in the same coordinate space.

  3. This dirty rect which remains in images space is adjusted during merging.

Blocks: blob-recoord

This is a follow up to bug 1564655. It removes the offset from ToDeviceSpace
and thus moves item rects into absolute space which is now the same coordinate
space as the recordings are in.

We also adjust item bounds for fallback blobs.

Some additional changes that need happen to:

  1. In Moz2DImageRenderer we can reunify the origin because the recording and
    the recording metadata return to using the same coordinate space.

  2. The calls to PushLayer can return to using the item bounds
    which are now in the same coordinate space.

  3. This dirty rect which remains in images space is adjusted during merging.

Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5671bf0f8a21
Move the blob metadata from image space to an absolute space. r=nical
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → jmuizelaar
Regressions: 1570256
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: