Closed Bug 1566321 Opened 5 years ago Closed 5 years ago

[a11y] Arrow keys do not work in about:logins menu unless tab is pressed first

Categories

(Firefox :: about:logins, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox69 --- disabled
firefox70 - fixed

People

(Reporter: Jamie, Assigned: ntim)

References

Details

(Keywords: access, Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

Bug 1560359 made the about:logins menu keyboard accessible. However, the arrow keys don't work unless you first focus a menu item with the tab key.

STR:

  1. Enable the pref signon.management.page.enabled .
  2. Visit about:logins .
  3. Tab to the button to open the menu.
  4. Press enter to activate it.
  5. Press down arrow.
    • Expected: The first menu item should be focused.
    • Actual: It isn't.

Note that if you press tab before down arrow, down arrow does work after that.

In most menus of this type, the first menu item should be focused automatically after pressing the button, should it not? Should that happen as a fix for this bug as well?

The original patch did focus the first item in the menu when it opened, but I removed that due to a review comment. It can be added back in easily.

[Tracking Requested - why for this release]:

Priority: -- → P2
Whiteboard: [passwords:management] [skyline]

I don't think release management needs to specially track this, though it would be nice to fix for 70. Jaws, do you want to take this on?

Flags: needinfo?(jaws)
Keywords: regression
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Depends on: 1560359

:ntim, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Keywords: regression
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/af667e4c7419 Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta approval if you're comfortable doing so. It'll need a rebased patch if so, however.

Flags: needinfo?(ntim.bugs)
Flags: in-testsuite+
Flags: needinfo?(ntim.bugs)
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: